chrome/browser/safe_browsing/download_protection_service_unittest.cc - Issue 184563006: Move WriteFile and WriteFileDescriptor from file_util to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 184563006: Move WriteFile and WriteFileDescriptor from file_util to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/parsers/metadata_parser_filebase_unittest.cc ('K') | « chrome/browser/safe_browsing/download_feedback_unittest.cc ('k') | chrome/browser/shell_integration_linux.cc » ('j') | chrome/browser/ui/libgtk2ui/app_indicator_icon.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

index 34bcf1a3ddabff50b99c62c28f89cf9e0eda97af..ee82e27cdc287b235444877a81e517f6d5be6f35 100644

--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

@@ -710,7 +710,7 @@ TEST_F(DownloadProtectionServiceTest, CheckClientDownloadZip) {

base::ScopedTempDir zip_source_dir;

ASSERT_TRUE(zip_source_dir.CreateUniqueTempDir());

std::string file_contents = "dummy file";

- ASSERT_EQ(static_cast<int>(file_contents.size()), file_util::WriteFile(

+ ASSERT_EQ(static_cast<int>(file_contents.size()), base::WriteFile(

zip_source_dir.path().Append(FILE_PATH_LITERAL("file.txt")),

file_contents.data(), file_contents.size()));

ASSERT_TRUE(zip::Zip(zip_source_dir.path(), a_tmp, false));

@@ -725,7 +725,7 @@ TEST_F(DownloadProtectionServiceTest, CheckClientDownloadZip) {

Mock::VerifyAndClearExpectations(signature_util_.get());

// Now check with an executable in the zip file as well.

- ASSERT_EQ(static_cast<int>(file_contents.size()), file_util::WriteFile(

+ ASSERT_EQ(static_cast<int>(file_contents.size()), base::WriteFile(

zip_source_dir.path().Append(FILE_PATH_LITERAL("file.exe")),

file_contents.data(), file_contents.size()));

ASSERT_TRUE(zip::Zip(zip_source_dir.path(), a_tmp, false));

@@ -787,7 +787,7 @@ TEST_F(DownloadProtectionServiceTest, CheckClientDownloadCorruptZip) {

EXPECT_CALL(item, GetRemoteAddress()).WillRepeatedly(Return(""));

std::string file_contents = "corrupt zip file";

- ASSERT_EQ(static_cast<int>(file_contents.size()), file_util::WriteFile(

+ ASSERT_EQ(static_cast<int>(file_contents.size()), base::WriteFile(

a_tmp, file_contents.data(), file_contents.size()));

download_service_->CheckClientDownload(