Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 184563006: Move WriteFile and WriteFileDescriptor from file_util to base namespace. (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Move WriteFile and WriteFileDescriptor from file_util to base namespace. R=viettrungluu@chromium.org TBR=viettrungluu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255418

Patch Set 1 #

Total comments: 17

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -611 lines) Patch
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.h View 1 1 chunk +9 lines, -7 lines 0 comments Download
M base/file_util_posix.cc View 2 chunks +28 lines, -28 lines 0 comments Download
M base/file_util_unittest.cc View 1 9 chunks +9 lines, -10 lines 0 comments Download
M base/file_util_win.cc View 1 2 3 chunks +20 lines, -20 lines 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/files/file_util_proxy_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M base/json/json_file_value_serializer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M base/json/json_value_serializer_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/path_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/process/memory_linux.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M base/process/process_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sync_socket_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/shortcut_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M cc/test/pixel_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_write_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/default_app_order_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/external_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/zip_file_creator_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/resource_loader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_image_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_manager_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/power_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/user_policy_disk_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/owner_key_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/component_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/test_extension_dir.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_internal_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google/google_update_settings_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/pwg_raster_converter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/media/webrtc_log_uploader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/iapps_finder_impl_win_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_data_provider_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_folder_finder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/test/mock_nacl_gdb.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/net/crl_set_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/test/local_policy_test_server.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/download_feedback_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_feedback_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/history_data_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/certificate_dialogs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/app_indicator_icon.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/metro_pin_tab_helper_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/auto_start_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util_unittest.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/common/importer/firefox_importer_utils_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/mac/mock_launchd.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/media_galleries/picasa_test_util.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/media_galleries/pmp_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/url_fixer_upper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/install_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/logging_installer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/installer/util/logging_installer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/self_cleaning_temp_dir_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/mock_printer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/connector_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/zip_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/convert_dict_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/tools/profile_reset/jtl_compiler_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/safe_browsing/sb_sigutil.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/extensions/unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/extensions/unpacker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/image_writer/image_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/media_galleries/pmp_column_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/cros_disks_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/session_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/process_proxy/process_output_watcher_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/process_proxy/process_proxy.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cloud_print/gcp20/prototype/print_job_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cloud_print/gcp20/prototype/printer_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/data_driven_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_context_keyed_service/browser_context_dependency_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/resource_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M components/policy/core/common/config_dir_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/image_capture_device_manager_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_file_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac_fontloading_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/async_file_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/image_decoder_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M courgette/courgette_tool.cc View 1 chunk +1 line, -1 line 0 comments Download
M courgette/ensemble_apply.cc View 1 chunk +1 line, -1 line 0 comments Download
M courgette/third_party/bsdiff_apply.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/leveldb_value_store_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_resource_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/upload_data_stream_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M net/base/upload_file_element_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/block_files_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M net/disk_cache/simple/simple_version_upgrade_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/transport_security_persister_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/crl_set_dump/crl_set_dump.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M printing/backend/cups_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/image.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/config_file_watcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/json_host_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/image_operations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_write_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/gyp_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/trace.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/imagediff/image_diff.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/ozone/impl/file_surface_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/appcache/appcache_database_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/appcache/appcache_storage_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/local_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 9 months ago (2014-02-28 21:24:28 UTC) #1
viettrungluu
LGTM w/lots of nits. You should also go through the remaining files and fix indentation ...
6 years, 9 months ago (2014-02-28 21:47:23 UTC) #2
brettw
6 years, 9 months ago (2014-03-06 20:42:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r255418.

Powered by Google App Engine
This is Rietveld 408576698