Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1845623002: SkPDF: Use Pathops clipping (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org, caryclark
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Use Pathops clipping Turn this on all the time. Remove the SK_PDF_USE_PATHOPS_CLIPPING define that used to hide this functionality. All rendering tests are the same or improved by this. Also, remove non-functional SK_ALLOW_LARGE_PDF_SCALARS. TBR=reed@google.com removing dead #defines from SkUserConfig.h BUG=591805 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845623002 Committed: https://skia.googlesource.com/skia/+/dda239e25b54f4265734c62e2fdc76c872406f28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M include/config/SkUserConfig.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845623002/1
4 years, 8 months ago (2016-03-30 16:40:13 UTC) #3
hal.canary
PTAL
4 years, 8 months ago (2016-03-30 16:41:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 16:55:04 UTC) #7
tomhudson
We still need the alternative non-pathops code? LGTM
4 years, 8 months ago (2016-03-31 13:59:10 UTC) #8
hal.canary
On 2016/03/31 13:59:10, tomhudson wrote: > We still need the alternative non-pathops code? I will ...
4 years, 8 months ago (2016-03-31 14:30:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845623002/1
4 years, 8 months ago (2016-03-31 14:30:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/8250)
4 years, 8 months ago (2016-03-31 14:32:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845623002/1
4 years, 8 months ago (2016-03-31 14:33:03 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 14:34:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dda239e25b54f4265734c62e2fdc76c872406f28

Powered by Google App Engine
This is Rietveld 408576698