src/compiler/ia32/instruction-scheduler-ia32.cc - Issue 1845603002: [ia32] Byte and word memory operands in ia32 cmp/test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ia32/instruction-scheduler-ia32.cc

Issue 1845603002: [ia32] Byte and word memory operands in ia32 cmp/test. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Update. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ia32/instruction-scheduler-ia32.cc

diff --git a/src/compiler/ia32/instruction-scheduler-ia32.cc b/src/compiler/ia32/instruction-scheduler-ia32.cc

index f31542fc93b5dc29a90a663ac3ed2df49d14f228..803fdf6fd6905b77a74dfc41f93dd29c9ca4afac 100644

--- a/src/compiler/ia32/instruction-scheduler-ia32.cc

+++ b/src/compiler/ia32/instruction-scheduler-ia32.cc

@@ -17,7 +17,11 @@ int InstructionScheduler::GetTargetInstructionFlags(

case kIA32Add:

case kIA32And:

case kIA32Cmp:

+ case kIA32Cmp16:

+ case kIA32Cmp8:

case kIA32Test:

+ case kIA32Test16:

+ case kIA32Test8:

case kIA32Or:

case kIA32Xor:

case kIA32Sub: