Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1845603002: [ia32] Byte and word memory operands in ia32 cmp/test. (Closed)

Created:
4 years, 8 months ago by epertoso
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Byte and word memory operands in ia32 cmp/test. Currently, if the size of two cmp or test operands is a byte or a word, we sign-extend or zero-extend each of them into a 32-bit register before doing the comparison, even when the conditions for the use of a memory operand are met. This CL makes it possible to load only one of them into a register and address the other as a memory operand. The tricky bit is that, unlike as in the x64 counterpart http://crrev.com/1780193003, not all registers can be accessed as bytes. BUG= Committed: https://crrev.com/3dd3beb06676fe8030d1fef9086cbe63e4a4376d Cr-Commit-Position: refs/heads/master@{#35199}

Patch Set 1 : Update. #

Patch Set 2 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -53 lines) Patch
D src/compiler/ia32/code-generator-ia32.cc View 2 chunks +41 lines, -30 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 5 chunks +74 lines, -22 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +12 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
epertoso
4 years, 8 months ago (2016-03-30 15:44:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845603002/40001
4 years, 8 months ago (2016-03-30 15:44:35 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 16:07:55 UTC) #9
epertoso
PTAL
4 years, 8 months ago (2016-04-01 09:30:16 UTC) #12
Benedikt Meurer
LGTM.
4 years, 8 months ago (2016-04-01 10:40:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845603002/40001
4 years, 8 months ago (2016-04-01 10:44:13 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-01 11:07:36 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 11:09:07 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dd3beb06676fe8030d1fef9086cbe63e4a4376d
Cr-Commit-Position: refs/heads/master@{#35199}

Powered by Google App Engine
This is Rietveld 408576698