Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1845563003: Skip checking of IMPORT_EXPERIMENTAL_MIRRORS warning in analyze_test_test. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip checking of IMPORT_EXPERIMENTAL_MIRRORS warning in analyze_test_test. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/612d81466af236ff7569e424f520c5fca9d9970a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -15 lines) Patch
M tests/compiler/dart2js/analyze_helper.dart View 4 chunks +13 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_test_test.dart View 1 2 chunks +35 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-03-30 09:39:36 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/1845563003/diff/1/tests/compiler/dart2js/analyze_test_test.dart File tests/compiler/dart2js/analyze_test_test.dart (right): https://codereview.chromium.org/1845563003/diff/1/tests/compiler/dart2js/analyze_test_test.dart#newcode55 tests/compiler/dart2js/analyze_test_test.dart:55: // TODO(johnniwinther): Support checking of this warning. Is ...
4 years, 8 months ago (2016-03-30 09:43:50 UTC) #3
Johnni Winther
https://codereview.chromium.org/1845563003/diff/1/tests/compiler/dart2js/analyze_test_test.dart File tests/compiler/dart2js/analyze_test_test.dart (right): https://codereview.chromium.org/1845563003/diff/1/tests/compiler/dart2js/analyze_test_test.dart#newcode55 tests/compiler/dart2js/analyze_test_test.dart:55: // TODO(johnniwinther): Support checking of this warning. On 2016/03/30 ...
4 years, 8 months ago (2016-03-30 10:04:02 UTC) #4
Johnni Winther
4 years, 8 months ago (2016-03-30 10:12:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
612d81466af236ff7569e424f520c5fca9d9970a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698