Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2276)

Issue 1845563002: Make enclosingBlockFlowElement() to take const Node reference (Closed)

Created:
4 years, 8 months ago by yosin_UTC9
Modified:
4 years, 8 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make enclosingBlockFlowElement() to take const Node reference This patch makes |enclosingBlockFlowElement()| to take |const Node&| instead of |Node&| for improve code health. This patch is a preparation of http://crrev.com/1847483002, clean up |leadingWhitespacePosition()|. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/a5aaee4ce3189ef28d9557707e7971b87dea3e35 Cr-Commit-Position: refs/heads/master@{#383938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 8 months ago (2016-03-30 08:15:39 UTC) #3
tkent
lgtm
4 years, 8 months ago (2016-03-30 08:20:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845563002/1
4 years, 8 months ago (2016-03-30 08:21:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 09:24:57 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 09:26:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5aaee4ce3189ef28d9557707e7971b87dea3e35
Cr-Commit-Position: refs/heads/master@{#383938}

Powered by Google App Engine
This is Rietveld 408576698