Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1845553002: [crankshaft] Get rid of the StoreFrameContext instruction. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Get rid of the StoreFrameContext instruction. Context is always available through deopt data, so there should be no need to store the context back to the frame every time. (Turbofan already does not store back to the frame.) Committed: https://crrev.com/6f75a216f1b709c2fb5fbced5e9deaa61ba3affe Cr-Commit-Position: refs/heads/master@{#35125}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -272 lines) Patch
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 4 chunks +0 lines, -16 lines 2 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jarin
Red only CL; could you take a look, please?
4 years, 8 months ago (2016-03-30 07:06:02 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/1845553002/diff/1/src/crankshaft/hydrogen.cc File src/crankshaft/hydrogen.cc (left): https://codereview.chromium.org/1845553002/diff/1/src/crankshaft/hydrogen.cc#oldcode4706 src/crankshaft/hydrogen.cc:4706: AddSimulate(stmt->EntryId(), REMOVABLE_SIMULATE); Please also remove this BailoutId from the ...
4 years, 8 months ago (2016-03-30 07:07:56 UTC) #3
Benedikt Meurer
As discussed offline, let's leave it this way for now, and clean it up once ...
4 years, 8 months ago (2016-03-30 07:19:00 UTC) #4
Benedikt Meurer
LGTM
4 years, 8 months ago (2016-03-30 07:19:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845553002/1
4 years, 8 months ago (2016-03-30 07:19:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 07:21:23 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 07:23:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f75a216f1b709c2fb5fbced5e9deaa61ba3affe
Cr-Commit-Position: refs/heads/master@{#35125}

Powered by Google App Engine
This is Rietveld 408576698