MD Settings: convert startup pages to use BrowserProxy/WebUIListeners

chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{
  *   'title': string,
  *   'tooltip': string,
  *   'url': string
  * }}
  */
 var StartupPageInfo;
 
 /**
  * @fileoverview 'settings-startup-urls-page' is the settings page
  * containing the urls that will be opened when chrome is started.
  *
  * Example:
  *
  *    <neon-animated-pages>
  *      <settings-startup-urls-page prefs="{{prefs}}">
  *      </settings-startup-urls-page>
  *      ... other pages ...
  *    </neon-animated-pages>
  */
 Polymer({
   is: 'settings-startup-urls-page',
 
+  behaviors: [WebUIListenerBehavior],
+
   properties: {
     /**
      * Preferences state.
      */
     prefs: {
       type: Object,
       notify: true,
     },
 
+    /** @type {settings.StartupUrlsPageBrowserProxy} */
+    browserProxy_: Object,
+
     /** @private {string} */
     newUrl_: {
       type: String,
       value: '',
     },
 
     /**
      * Pages to load upon browser startup.
      * @private {!Array<!StartupPageInfo>}
      */
     startupPages_: Array,
   },
 
   attached: function() {
-    var self = this;
-    cr.define('Settings', function() {
-      return {
-        updateStartupPages: function() {
-          return self.updateStartupPages_.apply(self, arguments);
-        },
-      };
-    });
-    chrome.send('onStartupPrefsPageLoad');
+    this.addWebUIListener('update-startup-pages',
+                          this.updateStartupPages_.bind(this));
+    this.browserProxy_ = settings.StartupUrlsPageBrowserProxyImpl.getInstance();
+    this.browserProxy_.loadStartupPages();
   },
 
+  /**

[dschuyler, 2016/03/30 23:14:40]

Should there be an @param for the url

[Dan Beam, 2016/03/31 00:06:28]

Done.

+   * @return {string} A set of icon URLs.
+   * @private
+   */
   getIconSet_: function(url) {
     return getFaviconImageSet(url);
   },
 
   /** @private */
   updateStartupPages_: function(startupPages) {
     this.startupPages_ = startupPages;
   },
 
   /** @private */
   onAddPageTap_: function() {
     this.newUrl_ = '';
     this.$.addUrlDialog.open();
   },
 
   /** @private */
   onUseCurrentPagesTap_: function() {
-    chrome.send('setStartupPagesToCurrentPages');
+    this.browserProxy_.useCurrentPages();
   },
 
   /** @private */
   onCancelTap_: function() {
     this.$.addUrlDialog.close();
   },
 
   /**
    * @return {boolean} Whether tapping the Add button should be allowed.
    * @private
    */
   isAddEnabled_: function() {
-    return this.newUrl_.trim().length > 0;
+    return this.browserProxy_ && this.browserProxy_.canAddPage(this.newUrl_);

[Dan Beam, 2016/03/30 02:30:23]

i don't currently know whether the "this.browserProxy_ &&" is correct, but it is
required

[dschuyler, 2016/03/30 23:14:40]

I asked Demetrios about it.  He suggested changing the 
browserProxy initialization from |attached| to |ready|.

[Dan Beam, 2016/03/31 00:06:28]

Done. (had to initialize browserProxy_ in created)

   },
 
   /** @private */
   onAddTap_: function() {
     assert(this.isAddEnabled_());
-    chrome.send('addStartupPage', [this.newUrl_.trim()]);
+    this.browserProxy_.addStartupPage(this.newUrl_);
     this.$.addUrlDialog.close();
   },
 
   /**
    * @param {!{model: !{index: number}}} e
    * @private
    */
   onRemoveUrlTap_: function(e) {
-    chrome.send('removeStartupPage', [e.model.index]);
+    this.browserProxy_.removeStartupPage(e.model.index);
   },
 });