third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h - Issue 1845463002: Start implementing ForeignFetchEvent for foreign fetch events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

Issue 1845463002: Start implementing ForeignFetchEvent for foreign fetch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

index 7fc8a51838a0ab240297befbcc785be248f4056c..b87cd8b0deabaf7b313fc0768e532ea82392b94c 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

@@ -22,9 +22,11 @@ class ScriptValue;

// This class observes the service worker's handling of a FetchEvent and

// notifies the client.

-class MODULES_EXPORT RespondWithObserver final : public GarbageCollectedFinalized<RespondWithObserver>, public ContextLifecycleObserver {

+class MODULES_EXPORT RespondWithObserver : public GarbageCollectedFinalized<RespondWithObserver>, public ContextLifecycleObserver {

USING_GARBAGE_COLLECTED_MIXIN(RespondWithObserver);

public:

+ virtual ~RespondWithObserver();

static RespondWithObserver* create(ExecutionContext*, int eventID, const KURL& requestURL, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType, WebURLRequest::RequestContext);

void contextDestroyed() override;

@@ -36,15 +38,16 @@ public:

void respondWith(ScriptState*, ScriptPromise, ExceptionState&);

void responseWasRejected(WebServiceWorkerResponseError);

- void responseWasFulfilled(const ScriptValue&);

+ virtual void responseWasFulfilled(const ScriptValue&);

DECLARE_VIRTUAL_TRACE();

+protected:

+ RespondWithObserver(ExecutionContext*, int eventID, const KURL& requestURL, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType, WebURLRequest::RequestContext);

private:

class ThenFunction;

- RespondWithObserver(ExecutionContext*, int eventID, const KURL& requestURL, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType, WebURLRequest::RequestContext);

int m_eventID;

KURL m_requestURL;

WebURLRequest::FetchRequestMode m_requestMode;