Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1845453002: Use newline-separated human-readable pylint check names in webkitpy/pylintrc. (Closed)

Created:
4 years, 8 months ago by qyearsley
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use newline-separated human-readable pylint check names in webkitpy/pylintrc. Reason: This may make it easier to see what's disabled and enable some of the checks. BUG=598897 Committed: https://crrev.com/b75beff33786a002c942e2a571e87c9a0b344f86 Cr-Commit-Position: refs/heads/master@{#384015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -33 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/pylintrc View 1 chunk +32 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 8 months ago (2016-03-29 23:55:36 UTC) #3
Dirk Pranke
rubberstamp lgtm.
4 years, 8 months ago (2016-03-30 00:19:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845453002/1
4 years, 8 months ago (2016-03-30 16:14:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 17:25:54 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 17:26:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b75beff33786a002c942e2a571e87c9a0b344f86
Cr-Commit-Position: refs/heads/master@{#384015}

Powered by Google App Engine
This is Rietveld 408576698