Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1845443003: [wasm] Mask shift counts on architectures that don't implicitly mask. (Closed)

Created:
4 years, 8 months ago by titzer
Modified:
4 years, 8 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Mask shift counts on architectures that don't implicitly mask. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/d167c3743daacff6a67473a13b369ac02fc77fd1 Cr-Commit-Position: refs/heads/master@{#35136}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Move tests to test-run-wasm-64 #

Patch Set 3 : Spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -6 lines) Patch
M src/compiler/wasm-compiler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 4 chunks +41 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm-i32.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm-u32.js View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 8 months ago (2016-03-30 11:54:55 UTC) #1
ahaas
lgtm, it's really great that you fix my problems. https://codereview.chromium.org/1845443003/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/1845443003/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode363 test/cctest/wasm/test-run-wasm.cc:363: ...
4 years, 8 months ago (2016-03-30 12:00:09 UTC) #2
titzer
https://codereview.chromium.org/1845443003/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/1845443003/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode363 test/cctest/wasm/test-run-wasm.cc:363: TEST(Run_WasmI64Shl) { On 2016/03/30 12:00:08, ahaas wrote: > This ...
4 years, 8 months ago (2016-03-30 12:10:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845443003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845443003/40001
4 years, 8 months ago (2016-03-30 12:19:19 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-30 12:38:53 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 12:40:27 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d167c3743daacff6a67473a13b369ac02fc77fd1
Cr-Commit-Position: refs/heads/master@{#35136}

Powered by Google App Engine
This is Rietveld 408576698