Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 184543003: Adding flag to switch bench_record into tilegrid mode (Closed)

Created:
6 years, 9 months ago by iancottrell
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Adding flag to switch bench_record into tilegrid mode BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13628

Patch Set 1 #

Total comments: 5

Patch Set 2 : Name changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M tools/bench_record.cpp View 1 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
iancottrell
running bench_record with --tile_grid_size 512 after this patch is much more realistic of what chrome ...
6 years, 9 months ago (2014-02-28 16:35:13 UTC) #1
Sami
https://codereview.chromium.org/184543003/diff/1/tools/bench_record.cpp File tools/bench_record.cpp (right): https://codereview.chromium.org/184543003/diff/1/tools/bench_record.cpp#newcode29 tools/bench_record.cpp:29: DEFINE_int32(tile_grid_size, 0, "Set the tile grid size, if non ...
6 years, 9 months ago (2014-02-28 17:02:35 UTC) #2
mtklein
Other than the name nits, looks fine to me. I have no opinion on whether ...
6 years, 9 months ago (2014-02-28 17:27:38 UTC) #3
iancottrell
Incidentally, running bench record with all the bbox types... Nothing : 21.84 R Tree : ...
6 years, 9 months ago (2014-02-28 18:50:46 UTC) #4
mtklein
On 2014/02/28 18:50:46, iancottrell wrote: > Incidentally, running bench record with all the bbox types... ...
6 years, 9 months ago (2014-02-28 18:52:44 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-02-28 18:52:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/iancottrell@google.com/184543003/20001
6 years, 9 months ago (2014-02-28 18:53:01 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 19:25:13 UTC) #8
Message was sent while issue was closed.
Change committed as 13628

Powered by Google App Engine
This is Rietveld 408576698