Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1845423003: Allow node tests to break on travis (Closed)

Created:
4 years, 8 months ago by vsm
Modified:
4 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow node tests to break on travis Sorry for the spam. Browser tests are now working, but node cannot find the SDK: https://travis-ci.org/dart-lang/dev_compiler/jobs/119936690 I suspect you're breaking this anyway? TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/45dfc74642eed5f726d4aa33db598ff656fbf359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .travis.yml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as 45dfc74642eed5f726d4aa33db598ff656fbf359 (presubmit successful).
4 years, 8 months ago (2016-03-31 22:23:22 UTC) #2
Jennifer Messerly
4 years, 8 months ago (2016-04-04 16:28:59 UTC) #3
Message was sent while issue was closed. 
lgtm, thank you!

Powered by Google App Engine
This is Rietveld 408576698