Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1845403003: Begin implementing type inference for AST summaries. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin implementing type inference for AST summaries. As much as possible, we re-use the logic of InstanceMemberInferrer. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2706796239cab32801a0156bbccebf1c52d9114b

Patch Set 1 #

Patch Set 2 : Break a long line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+631 lines, -131 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 37 chunks +574 lines, -41 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 46 chunks +51 lines, -80 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-03-31 21:31:39 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-03-31 21:50:25 UTC) #3
Paul Berry
4 years, 8 months ago (2016-03-31 22:12:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2706796239cab32801a0156bbccebf1c52d9114b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698