Makes MaterialDesignController initialization explicit

chrome/browser/ui/startup/bad_flags_prompt.cc

Index: chrome/browser/ui/startup/bad_flags_prompt.cc
diff --git a/chrome/browser/ui/startup/bad_flags_prompt.cc b/chrome/browser/ui/startup/bad_flags_prompt.cc
index ecab67341faa382fb7bac37d5f7ebc9461070505..51039e243cb2adaebd1fc087a7767dd4bd635437 100644
--- a/chrome/browser/ui/startup/bad_flags_prompt.cc
+++ b/chrome/browser/ui/startup/bad_flags_prompt.cc
@@ -134,7 +134,7 @@ void MaybeShowInvalidUserDataDirWarningDialog() {
     if (locale.empty())
       locale = kUserDataDirDialogFallbackLocale;
     ui::ResourceBundle::InitSharedInstanceWithLocale(
-        locale, NULL, ui::ResourceBundle::LOAD_COMMON_RESOURCES);
+        locale, NULL, ui::ResourceBundle::DO_NOT_LOAD_COMMON_RESOURCES);

[sky, 2016/04/11 15:32:40]

Why do you need this change?

[varkha, 2016/04/11 19:30:58]

We only load resources here to get the 2 strings and then cleanup immediately in
line 147 below. LOAD_COMMON_RESOURCES would load other resources as well and
would need to have MDC initialized before that (and with this CL that would
assert).
MaybeShowInvalidUserDataDirWarningDialog is invoked before the local state is
loaded so MDC would not yet be initialized.
An alternative would be to init and uninit MDC here but since that would be the
only place in our code base (other than tests) to require MDC::Uninitialize I
prefer to just cdo this change here.

   }
 
   const base::string16& title =