Makes MaterialDesignController initialization explicit

ui/base/material_design/material_design_controller_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/base/test/material_design_controller_test_api.h"
 #include "ui/base/ui_base_switches.h"
 
 namespace ui {
 namespace {
 
 // Test fixture for the MaterialDesignController class.
 class MaterialDesignControllerTest : public testing::Test {
  public:
   MaterialDesignControllerTest();
   ~MaterialDesignControllerTest() override;
 
+ protected:
   // testing::Test:
   void SetUp() override;
+  void TearDown() override;
+  void SetCommandLineSwitch(const std::string& value_string);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MaterialDesignControllerTest);
 };
 
 MaterialDesignControllerTest::MaterialDesignControllerTest() {
 }
 
 MaterialDesignControllerTest::~MaterialDesignControllerTest() {
 }
 
 void MaterialDesignControllerTest::SetUp() {
   testing::Test::SetUp();
+  MaterialDesignController::Initialize();
+}
 
-  // Ensure other tests aren't polluted by a Mode set in these tests. The Mode
-  // has to be cleared in SetUp and not in TearDown because when the test suite
-  // starts up it triggers a call to ResourceBundle::LoadCommonResources()
-  // which calls MaterialDesignController::IsModeMaterial(), thereby
-  // initializing the mode and potentially causing the first test to fail.
+void MaterialDesignControllerTest::TearDown() {
   test::MaterialDesignControllerTestAPI::UninitializeMode();
+  testing::Test::TearDown();
 }
 
+void MaterialDesignControllerTest::SetCommandLineSwitch(
+    const std::string& value_string) {
+#if defined(ENABLE_TOPCHROME_MD)
+  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+      switches::kTopChromeMD, value_string);
+#endif  // defined(ENABLE_TOPCHROME_MD)
+}
+
+class MaterialDesignControllerTestMaterial :
+    public MaterialDesignControllerTest {
+ public:
+  MaterialDesignControllerTestMaterial() {
+    SetCommandLineSwitch("material");
+  }
+};

[sky, 2016/04/11 15:32:41]

private: DISALLOW... for these.

[varkha, 2016/04/11 19:30:58]

Done.

+
+class MaterialDesignControllerTestHybrid : public MaterialDesignControllerTest {
+ public:
+  MaterialDesignControllerTestHybrid() {
+    SetCommandLineSwitch("material-hybrid");
+  }
+};
+
+class MaterialDesignControllerTestDefault :
+    public MaterialDesignControllerTest {
+ public:
+  MaterialDesignControllerTestDefault() {
+    SetCommandLineSwitch("");

[sky, 2016/04/11 15:32:41]

"" -> std::string()

[varkha, 2016/04/11 19:30:58]

Done.

+  }
+};
+
+class MaterialDesignControllerTestInvalid :
+    public MaterialDesignControllerTest {
+ public:
+  MaterialDesignControllerTestInvalid() {
+    const std::string kInvalidValue = "1nvalid-valu3";
+    SetCommandLineSwitch(kInvalidValue);
+  }
+};
+
 #if !defined(ENABLE_TOPCHROME_MD)
 
 // Verify the Mode maps to Mode::NON_MATERIAL when the compile time flag is not
 // defined.
 TEST_F(MaterialDesignControllerTest,
        NonMaterialModeWhenCompileTimeFlagDisabled) {
   EXPECT_EQ(MaterialDesignController::Mode::NON_MATERIAL,
             MaterialDesignController::GetMode());
 }
 
 #else
 
 // Verify command line value "material" maps to Mode::MATERIAL when the compile
 // time flag is defined.
-TEST_F(MaterialDesignControllerTest,
+TEST_F(MaterialDesignControllerTestMaterial,
        EnabledCommandLineValueMapsToMaterialModeWhenCompileTimeFlagEnabled) {
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kTopChromeMD, "material");
   EXPECT_EQ(MaterialDesignController::Mode::MATERIAL_NORMAL,
             MaterialDesignController::GetMode());
 }
 
 // Verify command line value "material-hybrid" maps to Mode::MATERIAL_HYBRID
 // when the compile time flag is defined.
 TEST_F(
-    MaterialDesignControllerTest,
+    MaterialDesignControllerTestHybrid,
     EnabledHybridCommandLineValueMapsToMaterialHybridModeWhenCompileTimeFlagEnabled) {
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kTopChromeMD, "material-hybrid");
   EXPECT_EQ(MaterialDesignController::Mode::MATERIAL_HYBRID,
             MaterialDesignController::GetMode());
 }
 
 // Verify command line value "" maps to the default mode when the compile time
 // flag is defined.
 TEST_F(
-    MaterialDesignControllerTest,
+    MaterialDesignControllerTestDefault,
     DisabledCommandLineValueMapsToNonMaterialModeWhenCompileTimeFlagEnabled) {
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kTopChromeMD, "");
   EXPECT_EQ(MaterialDesignController::DefaultMode(),
             MaterialDesignController::GetMode());
 }
 
 // Verify the current mode is reported as the default mode when no command line
 // flag is defined.
 TEST_F(MaterialDesignControllerTest,
        NoCommandLineValueMapsToNonMaterialModeWhenCompileTimeFlagEnabled) {
   ASSERT_FALSE(base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kTopChromeMD));
   EXPECT_EQ(MaterialDesignController::DefaultMode(),
             MaterialDesignController::GetMode());
 }
 
 // Verify an invalid command line value uses the default mode.
-TEST_F(MaterialDesignControllerTest, InvalidCommandLineValue) {
-  const std::string kInvalidValue = "1nvalid-valu3";
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kTopChromeMD, kInvalidValue);
+TEST_F(MaterialDesignControllerTestInvalid, InvalidCommandLineValue) {
   EXPECT_EQ(MaterialDesignController::DefaultMode(),
             MaterialDesignController::GetMode());
 }
 
-// Verify that MaterialDesignController::IsModeMaterial() will initialize the
-// mode if it hasn't been initialized yet.
-TEST_F(MaterialDesignControllerTest, IsModeMaterialInitializesMode) {
-  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kTopChromeMD, "material");
+// Verify that MaterialDesignController::IsModeMaterial() will be true when
+// initialized with command line flag "material".
+TEST_F(MaterialDesignControllerTestMaterial, IsModeMaterialInitializesMode) {
   EXPECT_TRUE(MaterialDesignController::IsModeMaterial());
 }
 
 #endif  // !defined(ENABLE_TOPCHROME_MD)
 
 }  // namespace
 }  // namespace ui