Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1845313003: Fix build for pedantic compilers. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix build for pedantic compilers. 1f895a06bd36 did not use parenthesis around a conjunction in a disjunction. NOTRY=true TBR=bmeurer@chromium.org Committed: https://crrev.com/489c6f43df05f5d33849bb8b1080434bf802b757 Cr-Commit-Position: refs/heads/master@{#35192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 8 months ago (2016-04-01 09:13:39 UTC) #1
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-01 09:14:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845313003/1
4 years, 8 months ago (2016-04-01 09:16:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 09:18:20 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 09:20:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/489c6f43df05f5d33849bb8b1080434bf802b757
Cr-Commit-Position: refs/heads/master@{#35192}

Powered by Google App Engine
This is Rietveld 408576698