Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 1845313002: [interpreter] A few code coverage improvements. (Closed)

Created:
4 years, 8 months ago by oth
Modified:
4 years, 8 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] A few code coverage improvements. Improves code coverage of bytecode array builder and constant array builder. Fixes initial index for constant pool slice for kQuad operands. BUG=v8:4280, chromium:599000 LOG=N TBR=rmcilroy@chromium.org Committed: https://crrev.com/0c32e98eab67704bfa0cbc76bf9f1541dc8371fe Cr-Commit-Position: refs/heads/master@{#35201}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -19 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/interpreter/constant-array-builder.cc View 1 chunk +1 line, -1 line 1 comment Download
M test/cctest/interpreter/test-interpreter.cc View 3 chunks +87 lines, -1 line 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 4 chunks +58 lines, -4 lines 0 comments Download
M test/unittests/interpreter/constant-array-builder-unittest.cc View 3 chunks +57 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
oth
Mythri, PTAL, this should raise coverage for the BytecodeArrayBuilder and the ConstantArrayBuilder.
4 years, 8 months ago (2016-03-31 16:06:41 UTC) #2
mythria
nice, lgtm.
4 years, 8 months ago (2016-04-01 09:40:02 UTC) #3
mythria
https://codereview.chromium.org/1845313002/diff/1/src/interpreter/constant-array-builder.cc File src/interpreter/constant-array-builder.cc (right): https://codereview.chromium.org/1845313002/diff/1/src/interpreter/constant-array-builder.cc#newcode62 src/interpreter/constant-array-builder.cc:62: zone, k8BitCapacity + k16BitCapacity, k32BitCapacity, OperandSize::kQuad); This also fixes ...
4 years, 8 months ago (2016-04-01 10:10:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845313002/1
4 years, 8 months ago (2016-04-01 12:07:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 12:08:58 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 12:09:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c32e98eab67704bfa0cbc76bf9f1541dc8371fe
Cr-Commit-Position: refs/heads/master@{#35201}

Powered by Google App Engine
This is Rietveld 408576698