Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1845283005: Makes ImageGrid work again (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
weiliangc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes ImageGrid work again It was possible we were passing an empty size to the PaintRecorder. BUG=none TEST=none R=weiliangc@chromium.org Committed: https://crrev.com/01dda9ad7c9d8128327c5a43417d8b219071147a Cr-Commit-Position: refs/heads/master@{#384945}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M ui/wm/core/image_grid.cc View 7 chunks +12 lines, -12 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
sky
https://codereview.chromium.org/1845283005/diff/1/ui/wm/core/image_grid.cc File ui/wm/core/image_grid.cc (right): https://codereview.chromium.org/1845283005/diff/1/ui/wm/core/image_grid.cc#newcode273 ui/wm/core/image_grid.cc:273: gfx::Size bounding_size(image_.width(), image_.height()); This is the important change. The ...
4 years, 8 months ago (2016-04-01 23:11:56 UTC) #1
weiliangc
LGTM Thanks for catching this.
4 years, 8 months ago (2016-04-04 14:51:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845283005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845283005/1
4 years, 8 months ago (2016-04-04 14:51:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 17:53:23 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 17:54:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01dda9ad7c9d8128327c5a43417d8b219071147a
Cr-Commit-Position: refs/heads/master@{#384945}

Powered by Google App Engine
This is Rietveld 408576698