src/effects/SkXfermodeImageFilter.cpp - Issue 1845283003: Gamma-correctness pushed into Skia, top-down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkXfermodeImageFilter.cpp

Issue 1845283003: Gamma-correctness pushed into Skia, top-down. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkXfermodeImageFilter.cpp

diff --git a/src/effects/SkXfermodeImageFilter.cpp b/src/effects/SkXfermodeImageFilter.cpp

index 45c9f70568c714711fb1486e42dc490d33b50b6a..c0dad12697c0e7cf849be337e5c3056d1464e3d2 100644

--- a/src/effects/SkXfermodeImageFilter.cpp

+++ b/src/effects/SkXfermodeImageFilter.cpp

@@ -173,6 +173,7 @@ bool SkXfermodeImageFilter::filterImageGPUDeprecated(Proxy* proxy,

}

GrPaint paint;

+ // SRGBTODO: AllowSRGBInputs?

bsalomon 2016/04/06 13:19:28 This in the deprecated code path, probably doesn't

SkAutoTUnref<const GrFragmentProcessor> bgFP;

if (backgroundTex) {