gm/constcolorprocessor.cpp - Issue 1845283003: Gamma-correctness pushed into Skia, top-down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/constcolorprocessor.cpp

Issue 1845283003: Gamma-correctness pushed into Skia, top-down. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/constcolorprocessor.cpp

diff --git a/gm/constcolorprocessor.cpp b/gm/constcolorprocessor.cpp

index 8c91a722eccd07a11b94efda440c6ff41f6e9aa8..37295c78cc573e31ab45d9b9ed547d83a0e7b86b 100644

--- a/gm/constcolorprocessor.cpp

+++ b/gm/constcolorprocessor.cpp

@@ -104,7 +104,8 @@ protected:

} else {

skPaint.setColor(kPaintColors[paintType]);

}

- SkAssertResult(SkPaintToGrPaint(context, skPaint, viewMatrix, &grPaint));

+ // SRGBTODO: No sRGB inputs allowed here?

+ SkAssertResult(SkPaintToGrPaint(context, skPaint, viewMatrix, false, &grPaint));

GrConstColorProcessor::InputMode mode = (GrConstColorProcessor::InputMode) m;

GrColor color = kColors[procColor];