src/effects/SkImageSource.cpp - Issue 1845283003: Gamma-correctness pushed into Skia, top-down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkImageSource.cpp

Issue 1845283003: Gamma-correctness pushed into Skia, top-down. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove helper function for old pixel-config method of enabling decode Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkImageSource.cpp

diff --git a/src/effects/SkImageSource.cpp b/src/effects/SkImageSource.cpp

index cf8cae2c3919da8634e3b40ac8b5cbd786ebdf80..6a4eb8d3aab1080080a07cf7f5282294b9e2550a 100644

--- a/src/effects/SkImageSource.cpp

+++ b/src/effects/SkImageSource.cpp

@@ -68,11 +68,13 @@ sk_sp<SkSpecialImage> SkImageSource::onFilterImage(SkSpecialImage* source, const

offset->fX = offset->fY = 0;

return SkSpecialImage::MakeFromImage(source->internal_getProxy(),

SkIRect::MakeWH(fImage->width(), fImage->height()),

- fImage);

+ fImage,

+ &source->props());

}

const SkIRect dstIRect = dstRect.roundOut();

+ // SRGBTODO: Propagate SkColorType?

const SkImageInfo info = SkImageInfo::MakeN32(dstIRect.width(), dstIRect.height(),

kPremul_SkAlphaType);