src/effects/SkAlphaThresholdFilter.cpp - Issue 1845283003: Gamma-correctness pushed into Skia, top-down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkAlphaThresholdFilter.cpp

Issue 1845283003: Gamma-correctness pushed into Skia, top-down. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove helper function for old pixel-config method of enabling decode Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkAlphaThresholdFilter.cpp

diff --git a/src/effects/SkAlphaThresholdFilter.cpp b/src/effects/SkAlphaThresholdFilter.cpp

index 5a9ad79a9ddef9ee5b1535541c8e08481e1ff1a9..10d3732e83bd41b5a01fe15a5490d2d78d63ec1a 100644

--- a/src/effects/SkAlphaThresholdFilter.cpp

+++ b/src/effects/SkAlphaThresholdFilter.cpp

@@ -312,6 +312,7 @@ bool SkAlphaThresholdFilterImpl::asFragmentProcessor(GrFragmentProcessor** fp,

context->drawContext(maskTexture->asRenderTarget()));

if (drawContext) {

GrPaint grPaint;

+ // SRGBTODO: AllowSRGBInputs?

bsalomon 2016/04/05 13:24:00 Nah, this is really drawing a mask.

Brian Osman 2016/04/05 15:36:41 Acknowledged.

grPaint.setPorterDuffXPFactory(SkXfermode::kSrc_Mode);

SkRegion::Iterator iter(fRegion);

drawContext->clear(nullptr, 0x0, true);