Gamma-correctness pushed into Skia, top-down.

include/core/SkCanvas.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkCanvas_DEFINED
 #define SkCanvas_DEFINED
 
@@ skipping 104 matching lines @@
     virtual ~SkCanvas();
 
     SkMetaData& getMetaData();
 
     /**
      *  Return ImageInfo for this canvas. If the canvas is not backed by pixels
      *  (cpu or gpu), then the info's ColorType will be kUnknown_SkColorType.
      */
     SkImageInfo imageInfo() const;
 
+    /**
+    *  Return SurfaceProps for this canvas. If the canvas is not backed by pixels
+    *  (cpu or gpu), then this will return null.

[reed1, 2016/04/04 21:12:29]

1. I think recording canvases have a device, so they will return true? Would it
be more correct to say the canvas has to be backed by a surface?

2. How do you feel about returning a copy of the props instead of a bare ptr?

e.g.

bool getProps(SurfaceProps*) const;

[Brian Osman, 2016/04/04 21:42:35]

My understanding (and Brian's claim) was that the recording canvases didn't have
a device. If they do, then the comment on imageInfo() is also wrong - that
function is also implemented to check for the device being null.
I'd be okay with that. It will make a bit more typing in some of the GMs that
I'm fixing up, but not enough to matter. This version of props() is already
strange, because every other class with an SkSurfaceProps accessor returns by
const-ref, so changing the name/signature more to call out the potential for
failure is probably good.

+    */
+    const SkSurfaceProps* props() const;
+
     ///////////////////////////////////////////////////////////////////////////
 
     /**
      *  Trigger the immediate execution of all pending draw operations. For the GPU
      *  backend this will resolve all rendering to the GPU surface backing the
      *  SkSurface that owns this canvas.
      */
     void flush();
 
     /**
@@ skipping 1434 matching lines @@
 
 class SkCanvasClipVisitor {
 public:
     virtual ~SkCanvasClipVisitor();
     virtual void clipRect(const SkRect&, SkRegion::Op, bool antialias) = 0;
     virtual void clipRRect(const SkRRect&, SkRegion::Op, bool antialias) = 0;
     virtual void clipPath(const SkPath&, SkRegion::Op, bool antialias) = 0;
 };
 
 #endif