Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1845243006: Fix SAML Interstitial not shown when pre-existing user pod exists (Closed)

Created:
4 years, 8 months ago by afakhry
Modified:
4 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SAML Interstitial not shown when pre-existing user pod exists This was due to a condition that always evaluated to false, when the gaia signin in screen has been previously loaded. BUG=599723 Committed: https://crrev.com/d63c2d5efb5b8cfd94e910ee3049b1faa3cd30c8 Cr-Commit-Position: refs/heads/master@{#384745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +15 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
afakhry
xiyuan, please review this CL. Thanks!
4 years, 8 months ago (2016-04-01 19:19:37 UTC) #2
xiyuan
lgtm
4 years, 8 months ago (2016-04-01 20:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243006/1
4 years, 8 months ago (2016-04-01 22:59:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 00:07:59 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 00:10:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d63c2d5efb5b8cfd94e910ee3049b1faa3cd30c8
Cr-Commit-Position: refs/heads/master@{#384745}

Powered by Google App Engine
This is Rietveld 408576698