[ic] Use the CallFunction builtin to invoke accessors.

[ic] Use the CallFunction builtin to invoke accessors.

The HandlerCompiler did not properly handle the weird edge case when a
sloppy mode function was installed as an accessor on one of the value
wrapper prototypes and then accessed via a load from a primitive value.
In this case we just passed the primitive value untouched instead of
properly wrapping it first. The CallFunction builtin properly deals with
all the funny edge cases, so we use it instead of duplicating almost all
of the logic here (the performance difference is neglible).

R=verwaest@chromium.org
BUG=chromium:599073, v8:4413
LOG=n

Committed: https://crrev.com/6df9a22c3f8d6640e867ca659c95e22289b00b40
Cr-Commit-Position: refs/heads/master@{#35187}

[Benedikt Meurer, 2016-04-01 05:22:46]

Hey Toon,

Remove another special case of call and use the CallFunction builtin instead for
the ICs (generic getter/setter case).
Please take a look.

Thanks,
Benedikt

[Benedikt Meurer, 2016-04-01 05:37:05]

Description was changed from

==========
[ic] Use the CallFunction builtin to invoke accessors.

The HandlerCompiler did not properly handle the weird edge case when a
sloppy mode function was installed as an accessor on one of the value
wrapper prototypes and then accessed via a load from a primitive value.
In this case we just passed the primitive value untouched instead of
properly wrapping it first. The CallFunction builtin properly deals with
all the funny edge cases, so we use it instead of duplicating almost all
of the logic here (the performance difference is neglible).

R=verwaest@chromium.org
BUG=chromium:599073
LOG=n
==========

to

==========
[ic] Use the CallFunction builtin to invoke accessors.

The HandlerCompiler did not properly handle the weird edge case when a
sloppy mode function was installed as an accessor on one of the value
wrapper prototypes and then accessed via a load from a primitive value.
In this case we just passed the primitive value untouched instead of
properly wrapping it first. The CallFunction builtin properly deals with
all the funny edge cases, so we use it instead of duplicating almost all
of the logic here (the performance difference is neglible).

R=verwaest@chromium.org
BUG=chromium:599073, v8:4413
LOG=n
==========

[Yang, 2016-04-01 06:35:37]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-04-01 06:35:38]

lgtm

[Benedikt Meurer, 2016-04-01 06:35:51]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-04-01 06:36:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845243005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845243005/60001

[commit-bot: I haz the power, 2016-04-01 06:37:43]

Description was changed from

==========
[ic] Use the CallFunction builtin to invoke accessors.

The HandlerCompiler did not properly handle the weird edge case when a
sloppy mode function was installed as an accessor on one of the value
wrapper prototypes and then accessed via a load from a primitive value.
In this case we just passed the primitive value untouched instead of
properly wrapping it first. The CallFunction builtin properly deals with
all the funny edge cases, so we use it instead of duplicating almost all
of the logic here (the performance difference is neglible).

R=verwaest@chromium.org
BUG=chromium:599073, v8:4413
LOG=n
==========

to

==========
[ic] Use the CallFunction builtin to invoke accessors.

The HandlerCompiler did not properly handle the weird edge case when a
sloppy mode function was installed as an accessor on one of the value
wrapper prototypes and then accessed via a load from a primitive value.
In this case we just passed the primitive value untouched instead of
properly wrapping it first. The CallFunction builtin properly deals with
all the funny edge cases, so we use it instead of duplicating almost all
of the logic here (the performance difference is neglible).

R=verwaest@chromium.org
BUG=chromium:599073, v8:4413
LOG=n
==========

[commit-bot: I haz the power, 2016-04-01 06:37:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-01 06:38:03]

Description was changed from

==========
[ic] Use the CallFunction builtin to invoke accessors.

The HandlerCompiler did not properly handle the weird edge case when a
sloppy mode function was installed as an accessor on one of the value
wrapper prototypes and then accessed via a load from a primitive value.
In this case we just passed the primitive value untouched instead of
properly wrapping it first. The CallFunction builtin properly deals with
all the funny edge cases, so we use it instead of duplicating almost all
of the logic here (the performance difference is neglible).

R=verwaest@chromium.org
BUG=chromium:599073, v8:4413
LOG=n
==========

to

==========
[ic] Use the CallFunction builtin to invoke accessors.

The HandlerCompiler did not properly handle the weird edge case when a
sloppy mode function was installed as an accessor on one of the value
wrapper prototypes and then accessed via a load from a primitive value.
In this case we just passed the primitive value untouched instead of
properly wrapping it first. The CallFunction builtin properly deals with
all the funny edge cases, so we use it instead of duplicating almost all
of the logic here (the performance difference is neglible).

R=verwaest@chromium.org
BUG=chromium:599073, v8:4413
LOG=n

Committed: https://crrev.com/6df9a22c3f8d6640e867ca659c95e22289b00b40
Cr-Commit-Position: refs/heads/master@{#35187}
==========

[commit-bot: I haz the power, 2016-04-01 06:38:04]

Patchset 4 (id:??) landed as
https://crrev.com/6df9a22c3f8d6640e867ca659c95e22289b00b40
Cr-Commit-Position: refs/heads/master@{#35187}