Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1845243004: Revert of Move make_scoped_ptr into //base/memory/ptr_util.h. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move make_scoped_ptr into //base/memory/ptr_util.h. (patchset #2 id:20001 of https://codereview.chromium.org/1838323002/ ) Reason for revert: No longer needed given the updated migration plan. Original issue's description: > Move make_scoped_ptr into //base/memory/ptr_util.h. > > Preparatory CL for renaming scoped_ptr to std::unique_ptr. One of the > changes is replacing all uses of make_scoped_ptr() with WrapUnique(), > which lives in a separate header. > > In order to incrementally update files to use the new header, this CL > moves make_scoped_ptr to ptr_util.h but still includes it in > scoped_ptr.h to avoid breaking the build during the transition. > > BUG=554298 > > Committed: https://crrev.com/e180e0b92e020144eb62530e561c9579cb0f35a7 > Cr-Commit-Position: refs/heads/master@{#383815} TBR=danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=554298 Committed: https://chromium.googlesource.com/chromium/src/+/eee3dc80bd14507345715a883db70c471f749880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M base/memory/ptr_util.h View 1 chunk +0 lines, -25 lines 0 comments Download
M base/memory/scoped_ptr.h View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
dcheng
Created Revert of Move make_scoped_ptr into //base/memory/ptr_util.h.
4 years, 8 months ago (2016-04-01 03:54:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243004/1
4 years, 8 months ago (2016-04-01 03:55:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243004/1
4 years, 8 months ago (2016-04-01 04:02:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243004/1
4 years, 8 months ago (2016-04-01 04:32:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243004/1
4 years, 8 months ago (2016-04-01 05:02:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243004/1
4 years, 8 months ago (2016-04-01 05:32:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243004/1
4 years, 8 months ago (2016-04-01 06:01:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243004/1
4 years, 8 months ago (2016-04-01 06:32:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243004/1
4 years, 8 months ago (2016-04-01 07:01:50 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eee3dc80bd14507345715a883db70c471f749880 Cr-Commit-Position: refs/heads/master@{#384506}
4 years, 8 months ago (2016-04-01 07:06:59 UTC) #11
dcheng
4 years, 8 months ago (2016-04-01 07:07:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eee3dc80bd14507345715a883db70c471f749880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698