Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1845243002: [regexp] extend \p syntax to binary and enumerated properties. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com, goyakin_microsoft.com, brian.terlson_microsoft.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] extend \p syntax to binary and enumerated properties. Also make the syntax a bit less complicated and speculative. R=littledan@chromium.org BUG=v8:4743 LOG=N Committed: https://crrev.com/e39ba01420733cf5fa7a16f9c91dcc8b8b044a47 Cr-Commit-Position: refs/heads/master@{#35344}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -89 lines) Patch
M src/regexp/regexp-parser.cc View 2 chunks +80 lines, -37 lines 0 comments Download
A test/mjsunit/harmony/regexp-property-binary.js View 1 chunk +25 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-blocks.js View 1 chunk +17 lines, -17 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-char-class.js View 2 chunks +3 lines, -3 lines 0 comments Download
A test/mjsunit/harmony/regexp-property-enumerated.js View 1 chunk +28 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-exact-match.js View 2 chunks +19 lines, -10 lines 1 comment Download
M test/mjsunit/harmony/regexp-property-scripts.js View 1 chunk +22 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
4 years, 8 months ago (2016-03-31 12:11:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243002/1
4 years, 8 months ago (2016-04-01 09:51:53 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 10:24:51 UTC) #5
Yang
On 2016/04/01 10:24:51, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-05 09:32:57 UTC) #6
Dan Ehrenberg
lgtm Sorry for the delay in review. I like this change, and it's fine to ...
4 years, 8 months ago (2016-04-07 22:13:25 UTC) #7
Yang
On 2016/04/07 22:13:25, Dan Ehrenberg wrote: > lgtm > > Sorry for the delay in ...
4 years, 8 months ago (2016-04-08 05:16:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845243002/1
4 years, 8 months ago (2016-04-08 05:16:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 05:39:35 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 05:39:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e39ba01420733cf5fa7a16f9c91dcc8b8b044a47
Cr-Commit-Position: refs/heads/master@{#35344}

Powered by Google App Engine
This is Rietveld 408576698