Store standalone web app data in WebappDataStorage as well as the homescreen intent.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.os.AsyncTask;
 
@@ skipping 20 matching lines @@
     static final String KEY_WEBAPP_SET = "webapp_set";
     static final String KEY_LAST_CLEANUP = "last_cleanup";
 
     /** Represents a period of 4 weeks in milliseconds */
     static final long FULL_CLEANUP_DURATION = TimeUnit.DAYS.toMillis(4L * 7L);
 
     /** Represents a period of 13 weeks in milliseconds */
     static final long WEBAPP_UNOPENED_CLEANUP_DURATION = TimeUnit.DAYS.toMillis(13L * 7L);
 
     /**
-     * Called when a retrieval of the stored web apps occurs.
+     * Called when a retrieval of the set of stored web app IDs occurs.
      */
     public interface FetchCallback {
-        public void onWebappIdsRetrieved(Set<String> readObject);
+        void onWebappIdsRetrieved(Set<String> readObject);
     }
 
     /**
-     * Registers the existence of a web app and creates the SharedPreference for it.
+     * Called when a retrieval of the stored WebappDataStorage occurs. The storage parameter will
+     * be null if the web app queried for was not in the registry.
+     */
+    public interface FetchWebappDataStorageCallback {
+        void onWebappDataStorageRetrieved(WebappDataStorage storage);
+    }
+
+    /**
+     * Registers the existence of a web app, creates the SharedPreference for it, and runs the
+     * supplied callback (if not null) on the UI thread with the resulting WebappDataStorage object.
      * @param context  Context to open the registry with.
      * @param webappId The id of the web app to register.
+     * @param callback The callback to run with the WebappDataStorage argument.
+     * @return The storage object for the web app.
      */
     public static void registerWebapp(final Context context, final String webappId,
-            final String scope) {
-        new AsyncTask<Void, Void, Void>() {
+            final FetchWebappDataStorageCallback callback) {
+        new AsyncTask<Void, Void, WebappDataStorage>() {
             @Override
-            protected final Void doInBackground(Void... nothing) {
+            protected final WebappDataStorage doInBackground(Void... nothing) {
                 SharedPreferences preferences = openSharedPreferences(context);
+                // The set returned by getRegisteredWebappIds must be treated as immutable, so we
+                // make a copy to edit and save.
                 Set<String> webapps = new HashSet<String>(getRegisteredWebappIds(preferences));
                 boolean added = webapps.add(webappId);
                 assert added;
 
-                // Update the last used time, so we can guarantee that a web app which appears in
-                // the registry will have a last used time != WebappDataStorage.LAST_USED_INVALID.
+                preferences.edit().putStringSet(KEY_WEBAPP_SET, webapps).apply();
+
+                // Create the WebappDataStorage and update the last used time, so we can guarantee
+                // that a web app which appears in the registry will have a
+                // last used time != WebappDataStorage.LAST_USED_INVALID.
                 WebappDataStorage storage = new WebappDataStorage(context, webappId);
-                storage.setScope(scope);
                 storage.updateLastUsedTime();
-                preferences.edit().putStringSet(KEY_WEBAPP_SET, webapps).apply();
-                return null;
+                return storage;
+            }
+
+            @Override
+            protected final void onPostExecute(WebappDataStorage storage) {
+                if (callback != null) callback.onWebappDataStorageRetrieved(storage);
             }
         }.execute();
     }
 
+    /**
+     * Runs the callback, supplying the WebappDataStorage object for webappId, or null if the web
+     * app has not been registered.
+     * @param context  Context to open the registry with.
+     * @param webappId The id of the web app to register.
+     * @return The storage object for the web app, or null if webappId is not registered.
+     */
+    public static void getWebappDataStorage(final Context context, final String webappId,
+            final FetchWebappDataStorageCallback callback) {
+        new AsyncTask<Void, Void, WebappDataStorage>() {
+            @Override
+            protected final WebappDataStorage doInBackground(Void... nothing) {
+                SharedPreferences preferences = openSharedPreferences(context);
+                if (getRegisteredWebappIds(preferences).contains(webappId)) {
+                    WebappDataStorage storage = WebappDataStorage.open(context, webappId);
+                    storage.updateLastUsedTime();
+                    return storage;
+                }
+                return null;
+            }
+
+            @Override
+            protected final void onPostExecute(WebappDataStorage storage) {
+                assert callback != null;
+                callback.onWebappDataStorageRetrieved(storage);
+            }
+        }.execute();
+    }
+
     /**
      * Asynchronously retrieves the list of web app IDs which this registry is aware of.
      * @param context  Context to open the registry with.
      * @param callback Called when the set has been retrieved. The set may be empty.
      */
     @VisibleForTesting
     public static void getRegisteredWebappIds(final Context context, final FetchCallback callback) {
         new AsyncTask<Void, Void, Set<String>>() {
             @Override
             protected final Set<String> doInBackground(Void... nothing) {
                 return getRegisteredWebappIds(openSharedPreferences(context));
             }
 
             @Override
             protected final void onPostExecute(Set<String> result) {
+                assert callback != null;
                 callback.onWebappIdsRetrieved(result);
             }
         }.execute();
     }
 
     /**
      * Deletes the data for all "old" web apps.
      * "Old" web apps have not been opened by the user in the last 3 months, or have had their last
      * used time set to 0 by the user clearing their history. Cleanup is run, at most, once a month.
      *
@@ skipping 56 matching lines @@
     static void unregisterAllWebapps(Context context, final long callbackPointer) {
         unregisterAllWebapps(context, new Runnable() {
             @Override
             public void run() {
                 nativeOnWebappsUnregistered(callbackPointer);
             }
         });
     }
 
     /**
-     * Deletes the scope and sets the last used time to 0 for all web apps.
+     * Deletes the URL and scope, and sets the last used time to 0 for all web apps.
      */
     @VisibleForTesting
     static void clearWebappHistory(final Context context, final Runnable callback) {
         new AsyncTask<Void, Void, Void>() {
             @Override
             protected final Void doInBackground(Void... nothing) {
                 SharedPreferences preferences = openSharedPreferences(context);
                 for (String id : getRegisteredWebappIds(preferences)) {
                     WebappDataStorage.clearHistory(context, id);
                 }
@@ skipping 27 matching lines @@
         return Collections.unmodifiableSet(
                 preferences.getStringSet(KEY_WEBAPP_SET, Collections.<String>emptySet()));
     }
 
     private WebappRegistry() {
     }
 
     private static native void nativeOnWebappsUnregistered(long callbackPointer);
     private static native void nativeOnClearedWebappHistory(long callbackPointer);
 }