LayoutTests/fast/hidpi/image-srcset-src-selection-1x-both.html - Issue 184523003: Fix two srcset related bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/hidpi/image-srcset-src-selection-1x-both.html

Issue 184523003: Fix two srcset related bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed a useless if Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html ('k') | LayoutTests/fast/hidpi/image-srcset-src-selection-1x-both-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/hidpi/image-srcset-src-selection-1x-both.html

diff --git a/LayoutTests/fast/hidpi/image-srcset-src-selection-1x.html b/LayoutTests/fast/hidpi/image-srcset-src-selection-1x-both.html

similarity index 66%

copy from LayoutTests/fast/hidpi/image-srcset-src-selection-1x.html

copy to LayoutTests/fast/hidpi/image-srcset-src-selection-1x-both.html

index 20710d034c27a31a9535ba0c1314e6eafc0c2726..aaead2b5800507810788ade0557548bf37a054b8 100644

--- a/LayoutTests/fast/hidpi/image-srcset-src-selection-1x.html

+++ b/LayoutTests/fast/hidpi/image-srcset-src-selection-1x-both.html

@@ -1,7 +1,7 @@

<html>

<head>

- window.targetScaleFactor = 1;

+ window.targetScaleFactor = 2;

</script>

@@ -11,13 +11,14 @@

}

addEventListener("load", function() {

- shouldBeTrue('document.getElementById("foo").clientWidth==100');

+ shouldBeTrue('document.getElementById("foo").clientWidth==400');

}, false);

</script>

</head>

- <div>This test passes if the div below is a blue 100px square when the deviceScaleFactor is 1. It simply ensures that the src attribute is taken into account by the selection algorithm when this one is processing the images candidates</div>

- <img id="foo" src="resources/blue-100-px-square.png" srcset="resources/green-400-px-square.png 2x">

+ <div>This test passes if the div below is a blue 100px square when the deviceScaleFactor is 1.

+ It simply ensures that when both src and srcset are specified for the same DPR, srcset wins.</div>

+ <img id="foo" src="resources/blue-100-px-square.png" srcset="resources/green-400-px-square.png 1x">

</body>

</html>