runtime/vm/deopt_instructions.cc - Issue 184523002: Allocation sinking for contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/deopt_instructions.cc

Issue 184523002: Allocation sinking for contexts. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: support Redefinitions in alias computation Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/deopt_instructions.cc

===================================================================

--- runtime/vm/deopt_instructions.cc (revision 41455)

+++ runtime/vm/deopt_instructions.cc (working copy)

@@ -1243,6 +1243,7 @@

MaterializeObjectInstr* mat = materializations_[i];

// Class of the instance to allocate.

AddConstant(mat->cls(), dest_index++);

+ AddConstant(Smi::Handle(Smi::New(mat->num_variables())), dest_index++);

Vyacheslav Egorov (Google) 2014/11/03 13:37:48 Can you avoid writing it if (mat->cls() != context

Florian Schneider 2014/11/04 13:28:57 I could - I'm not sure if it is worth making the D

for (intptr_t i = 0; i < mat->InputCount(); i++) {

if (!mat->InputAt(i)->BindsToConstantNull()) {

// Emit offset-value pair.