Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1845223005: Add Progressive JPEG YUV decoding layout tests (Closed)

Created:
4 years, 8 months ago by Noel Gordon
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Progressive JPEG YUV decoding layout tests See also issue 597127. Use a <meta> viewport tag to force GPU rasterization on the Android bots where supported and add test cases for images and for the <canvas> element: fast/images/jpeg-yuv-progressive-image.html fast/images/jpeg-yuv-progressive-canvas.html Add new Progressive JPEG image resources: they were built using the ImageMagik % convert -size <size> plasma:fractal -paint command. Details of the JPEG image encodings are: ycbcr-progressive-000.jpg Progressive DCT, Huffman coding Bits Per Sample 8 Color Components 3 Image Size 200 × 200 Y Cb Cr Sub Sampling YCbCr 4:4:4 (1 1) ycbcr-progressive-001.jpg Progressive DCT, Huffman coding Bits Per Sample 8 Color Components 3 Image Size 250 × 250 Y Cb Cr Sub Sampling YCbCr 4:4:4 (1 1) ycbcr-progressive-002.jpg Progressive DCT, Huffman coding Bits Per Sample 8 Color Components 3 Image Size 300 × 300 Y Cb Cr Sub Sampling YCbCr 4:2:0 (2 2) ycbcr-progressive-003.jpg Progressive DCT, Huffman coding Bits Per Sample 8 Color Components 3 Image Size 350 × 350 Y Cb Cr Sub Sampling YCbCr 4:2:0 (2 2) Note: the progressive images with YUV 4:2:0 encoding both cause the bug reported in issue 597127. The new tests added in this CL provide some test coverage for issue 597127 (run with --force-gpu-rasterization) but more work is needed to automate that on the bots, such as with a virtual test suite for this flag (it has none). TBR=scroggo@chromium.org BUG=598549 Committed: https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7 Cr-Commit-Position: refs/heads/master@{#384874}

Patch Set 1 #

Patch Set 2 : Add TestExpectations #

Patch Set 3 : Next round of trys #

Patch Set 4 : Try again after virtual test suite landed first: crbug.com/600087 #

Patch Set 5 : Yeap, need to add virtual tests to TestExpectations also #

Messages

Total messages: 33 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845223005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845223005/20001
4 years, 8 months ago (2016-04-01 06:50:23 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/203775)
4 years, 8 months ago (2016-04-01 07:24:50 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845223005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845223005/40001
4 years, 8 months ago (2016-04-01 22:16:36 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-02 00:26:59 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845223005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845223005/60001
4 years, 8 months ago (2016-04-04 05:38:58 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845223005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845223005/80001
4 years, 8 months ago (2016-04-04 06:31:52 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 07:42:56 UTC) #17
Noel Gordon
Finally, all test passing! Leon, I will land this now, but please review when you ...
4 years, 8 months ago (2016-04-04 08:39:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845223005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845223005/80001
4 years, 8 months ago (2016-04-04 08:40:19 UTC) #20
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-04 08:40:21 UTC) #22
Noel Gordon
On 2016/04/04 08:40:21, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 8 months ago (2016-04-04 09:50:19 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845223005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845223005/80001
4 years, 8 months ago (2016-04-04 09:50:38 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-04 09:55:45 UTC) #28
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/dca359146de5ca000b3e6681b91a468435b4f4b7 Cr-Commit-Position: refs/heads/master@{#384874}
4 years, 8 months ago (2016-04-04 09:57:00 UTC) #30
msarett
lgtm
4 years, 8 months ago (2016-04-04 13:55:16 UTC) #32
scroggo_chromium
4 years, 8 months ago (2016-04-04 19:15:03 UTC) #33
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698