Issue 18452012: Should not inherit style from control like element during inserting text just after deleting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18452012: Should not inherit style from control like element during inserting text just after deleting (Closed)

Created:
7 years, 5 months ago by yosin_UTC9

Modified:
7 years, 5 months ago

Reviewers:
leviw_travelin_and_unemployed, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, rniwa-cr

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

This patch changes initialization of typing style not to populate from form control like elements, which can't have range ending point, e.g. img, input, object, textarea, and so on. BUG=86938 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154067

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -0 lines)			Patch
A	LayoutTests/editing/inserting/insert-without-inheriting-style.html	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	LayoutTests/editing/inserting/insert-without-inheriting-style-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/editing/DeleteSelectionCommand.cpp	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/18452012/1

7 years, 5 months ago (2013-07-11 23:54:00 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 5 months ago (2013-07-12 00:52:29 UTC) #4

yosin_UTC9

7 years, 5 months ago (2013-07-12 01:32:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r154067 (presubmit successful).