third_party/WebKit/Source/core/editing/SelectionController.h - Issue 1845193002: Fix long-press image selection inside editables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.h

Issue 1845193002: Fix long-press image selection inside editables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable Mac-only failure (Mac doesn't support long-press anyway) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionController.h

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.h b/third_party/WebKit/Source/core/editing/SelectionController.h

index eb259ec8053f3831e6c177e8ffe9ce44b98fdfc7..849b5e04dacd79c20b3e6948868c1e29801706da 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.h

+++ b/third_party/WebKit/Source/core/editing/SelectionController.h

@@ -70,8 +70,9 @@ private:

explicit SelectionController(LocalFrame&);

enum class AppendTrailingWhitespace { ShouldAppend, DontAppend };

+ enum class SelectInputEventType { GestureLongPress, Mouse };

- void selectClosestWordFromHitTestResult(const HitTestResult&, AppendTrailingWhitespace);

+ void selectClosestWordFromHitTestResult(const HitTestResult&, AppendTrailingWhitespace, SelectInputEventType);

void selectClosestMisspellingFromHitTestResult(const HitTestResult&, AppendTrailingWhitespace);

void selectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&);

void selectClosestMisspellingFromMouseEvent(const MouseEventWithHitTestResults&);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »