Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: third_party/WebKit/Source/core/editing/SelectionController.h

Issue 1845193002: Fix long-press image selection inside editables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bring back containsOnlyWhitespace to address test flake Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2015 Google Inc. All rights reserved. 3 * Copyright (C) 2015 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 void setMouseDownMayStartSelect(bool); 64 void setMouseDownMayStartSelect(bool);
65 bool mouseDownMayStartSelect() const; 65 bool mouseDownMayStartSelect() const;
66 bool mouseDownWasSingleClickInSelection() const; 66 bool mouseDownWasSingleClickInSelection() const;
67 void notifySelectionChanged(); 67 void notifySelectionChanged();
68 68
69 private: 69 private:
70 explicit SelectionController(LocalFrame&); 70 explicit SelectionController(LocalFrame&);
71 71
72 enum class AppendTrailingWhitespace { ShouldAppend, DontAppend }; 72 enum class AppendTrailingWhitespace { ShouldAppend, DontAppend };
73 73
74 void selectClosestWordFromHitTestResult(const HitTestResult&, AppendTrailing Whitespace); 74 void selectClosestWordFromHitTestResult(const HitTestResult&, AppendTrailing Whitespace, bool isLongPress = false);
75 void selectClosestMisspellingFromHitTestResult(const HitTestResult&, AppendT railingWhitespace); 75 void selectClosestMisspellingFromHitTestResult(const HitTestResult&, AppendT railingWhitespace);
76 void selectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&); 76 void selectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&);
77 void selectClosestMisspellingFromMouseEvent(const MouseEventWithHitTestResul ts&); 77 void selectClosestMisspellingFromMouseEvent(const MouseEventWithHitTestResul ts&);
78 void selectClosestWordOrLinkFromMouseEvent(const MouseEventWithHitTestResult s&); 78 void selectClosestWordOrLinkFromMouseEvent(const MouseEventWithHitTestResult s&);
79 bool updateSelectionForMouseDownDispatchingSelectStart(Node*, const VisibleS electionInFlatTree&, TextGranularity); 79 bool updateSelectionForMouseDownDispatchingSelectStart(Node*, const VisibleS electionInFlatTree&, TextGranularity);
80 80
81 FrameSelection& selection() const; 81 FrameSelection& selection() const;
82 82
83 RawPtrWillBeMember<LocalFrame> const m_frame; 83 RawPtrWillBeMember<LocalFrame> const m_frame;
84 bool m_mouseDownMayStartSelect; 84 bool m_mouseDownMayStartSelect;
85 bool m_mouseDownWasSingleClickInSelection; 85 bool m_mouseDownWasSingleClickInSelection;
86 bool m_mouseDownAllowsMultiClick; 86 bool m_mouseDownAllowsMultiClick;
87 enum class SelectionState { HaveNotStartedSelection, PlacedCaret, ExtendedSe lection }; 87 enum class SelectionState { HaveNotStartedSelection, PlacedCaret, ExtendedSe lection };
88 SelectionState m_selectionState; 88 SelectionState m_selectionState;
89 }; 89 };
90 90
91 } // namespace blink 91 } // namespace blink
92 92
93 #endif // SelectionController_h 93 #endif // SelectionController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698