Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1845183002: X87: [wasm] Int64Lowering of Int64Mul on ia32 and arm. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Int64Lowering of Int64Mul on ia32 and arm. port 40bdbef975779e41a7e81d3748342dd7da52977f (r35131) original commit message: Int64Mul is lowered to a new turbofan operator, Int32MulPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the multiplication. BUG= Committed: https://crrev.com/25fe0e01eff879f63ab5242b632ac599ec063731 Cr-Commit-Position: refs/heads/master@{#35146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-03-31 02:52:14 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-03-31 05:38:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845183002/1
4 years, 8 months ago (2016-03-31 05:42:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 06:18:25 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 06:18:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25fe0e01eff879f63ab5242b632ac599ec063731
Cr-Commit-Position: refs/heads/master@{#35146}

Powered by Google App Engine
This is Rietveld 408576698