Certificate Transparency: Start tracking logs' state

net/cert/ct_verifier.h

Index: net/cert/ct_verifier.h
diff --git a/net/cert/ct_verifier.h b/net/cert/ct_verifier.h
index 46a811a79601d40001756e61a3f5924bbcf3eb4a..5d563af2c04fef937788cf0bcde905c4f6abac4b 100644
--- a/net/cert/ct_verifier.h
+++ b/net/cert/ct_verifier.h
@@ -26,6 +26,7 @@ class NET_EXPORT CTVerifier {
  public:
   class NET_EXPORT Observer {
    public:
+    virtual ~Observer() {}

[Ryan Sleevi, 2016/05/09 17:03:49]

Doesn't seem like this change belongs in this CL.

Should it instead be protected? This makes it clear that the API contract of
CTVerifier::Observer is that CTVerifier will not take ownership of the Observer
- that the Observer's lifetime semantics are left up to those implementing the
Observer interface.

[Eran Messeri, 2016/05/10 20:01:10]

Done - made it protected.

     // Called for each Signed Certificate Timestamp from a known log that vas
     // verified successfully (i.e. the signature verifies). |sct| is the
     // Signed Certificate Timestamp, |cert| is the certificate it applies to.