DirectX based screen capturer logic

webrtc/modules/desktop_capture/screen_capture_frame_queue.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_SCREEN_CAPTURE_FRAME_QUEUE_H_
 #define WEBRTC_MODULES_DESKTOP_CAPTURE_SCREEN_CAPTURE_FRAME_QUEUE_H_
 
 #include <memory>
 
+#include "webrtc/modules/desktop_capture/screen_capture_content_queue.h"
 #include "webrtc/modules/desktop_capture/shared_desktop_frame.h"
-#include "webrtc/typedefs.h"
 
 namespace webrtc {
 class DesktopFrame;
 }  // namespace webrtc
 
 namespace webrtc {
 
 // Represents a queue of reusable video frames. Provides access to the 'current'
 // frame - the frame that the caller is working with at the moment, and to the
 // 'previous' frame - the predecessor of the current frame swapped by
 // MoveToNextFrame() call, if any.
 //
 // The caller is expected to (re)allocate frames if current_frame() returns
 // NULL. The caller can mark all frames in the queue for reallocation (when,
 // say, frame dimensions change). The queue records which frames need updating
 // which the caller can query.
 //
 // Frame consumer is expected to never hold more than kQueueLength frames
 // created by this function and it should release the earliest one before trying
 // to capture a new frame (i.e. before MoveToNextFrame() is called).
-class ScreenCaptureFrameQueue {
+//
+// Users do not expect to call functions from
+// ScreenCaptureContentQueue<SharedDesktopFrame>, since extra assertions or
+// wrappers are applied.
+class ScreenCaptureFrameQueue : ScreenCaptureContentQueue<SharedDesktopFrame> {

[Sergey Ulanov, 2016/04/14 23:10:42]

Do we actually need this class? I'd prefer having a single
ScreenCaptureFrameQueue template and just instantiating it with
SharedDesktopFrame in the capturers that need it.

[Hzj_jie, 2016/04/15 19:42:17]

To avoid changing capturers which are not involved in this change, current
solution can make this change as smaller as possible.

  public:
-  ScreenCaptureFrameQueue();
-  ~ScreenCaptureFrameQueue();
+  ScreenCaptureFrameQueue() = default;
+  virtual ~ScreenCaptureFrameQueue() = default;
+
+  using ScreenCaptureContentQueue<SharedDesktopFrame>::Reset;
 
   // Moves to the next frame in the queue, moving the 'current' frame to become
   // the 'previous' one.
   void MoveToNextFrame();
 
   // Replaces the current frame with a new one allocated by the caller. The
   // existing frame (if any) is destroyed. Takes ownership of |frame|.
   void ReplaceCurrentFrame(DesktopFrame* frame);
 
-  // Marks all frames obsolete and resets the previous frame pointer. No
-  // frames are freed though as the caller can still access them.
-  void Reset();
-
   SharedDesktopFrame* current_frame() const {
-    return frames_[current_].get();
+    return current();
   }
 
   SharedDesktopFrame* previous_frame() const {

[Sergey Ulanov, 2016/04/14 23:10:42]

I don't think you need these two methods. Just change the capturers to call
current() and previous() directly

[Hzj_jie, 2016/04/15 19:42:17]

Same as above, let's do it in next change.

-    return frames_[(current_ + kQueueLength - 1) % kQueueLength].get();
+    return previous();
   }
 
- private:
-  // Index of the current frame.
-  int current_;
-
-  static const int kQueueLength = 2;
-  std::unique_ptr<SharedDesktopFrame> frames_[kQueueLength];
-
   RTC_DISALLOW_COPY_AND_ASSIGN(ScreenCaptureFrameQueue);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_DESKTOP_CAPTURE_SCREEN_CAPTURE_FRAME_QUEUE_H_