Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1845083003: Remove "#pragma comment(lib" in chrome. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina, wfh+watch_chromium.org, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "#pragma comment(lib" in chrome. BUG=597028 Committed: https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299 Cr-Commit-Position: refs/heads/master@{#384585}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -17 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/policy_path_parser_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/private_working_set_snapshot_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/certificate_viewer_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings_utils_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +17 lines, -1 line 0 comments Download
M chrome/chrome_installer_util.gypi View 2 chunks +36 lines, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/installer/util/html_dialog_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jam
4 years, 8 months ago (2016-04-01 01:00:59 UTC) #2
Nico
lgtm
4 years, 8 months ago (2016-04-01 01:03:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845083003/40001
4 years, 8 months ago (2016-04-01 03:41:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/203575)
4 years, 8 months ago (2016-04-01 06:22:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845083003/40001
4 years, 8 months ago (2016-04-01 14:41:28 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 15:09:18 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 15:10:25 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/66e4b2b2800e3dc683dbde2ede2bd8873a59c299
Cr-Commit-Position: refs/heads/master@{#384585}

Powered by Google App Engine
This is Rietveld 408576698