Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1845083002: Fix <webview> cursors with --site-per-process and --isolate-extensions. (Closed)

Created:
4 years, 8 months ago by avallee
Modified:
4 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix <webview> cursors with --site-per-process and --isolate-extensions. When running BrowserPlugin without either flag, the guest sets the cursor which is forwarded to the embedder. The embedder saves the current guest cursor and will set the cursor to the guest value when processing mouse events for the guest. When running with either --site-per-process or --isolate-extensions, the embedding renderer no longer receives the guest's mouse events which are how the cursor ends up being set. In this case, directly set the cursor with the owner view. BUG=595446 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/6071fe20d749ff6ebde0da65c5e3f6fd83065cb9 Cr-Commit-Position: refs/heads/master@{#384193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M content/browser/frame_host/render_widget_host_view_guest.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
avallee
PTAL
4 years, 8 months ago (2016-03-30 22:38:01 UTC) #3
Charlie Reis
Drive-by: Thanks for fixing! Can you CC site-isolation-reviews@chromium.org on future OOPIF-related CLs? That helps us ...
4 years, 8 months ago (2016-03-30 22:48:48 UTC) #4
piman
lgtm
4 years, 8 months ago (2016-03-31 01:37:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845083002/1
4 years, 8 months ago (2016-03-31 02:22:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 03:27:19 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 03:28:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6071fe20d749ff6ebde0da65c5e3f6fd83065cb9
Cr-Commit-Position: refs/heads/master@{#384193}

Powered by Google App Engine
This is Rietveld 408576698