Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1845073002: [Merge M50] Ensure that native WindowAndroid outlives native AwContents. (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Merge M50] Ensure that native WindowAndroid outlives native AwContents. ContentViewCore holds a window pointer that is used during destruction of native AwContents to remove observers. However the current CleanupReference based finalization scheme does not enforce an ordering on the destruction of native WindowAndroid and AwContents instances. Satisfaction of the constraint that AwContents is destroyed before WindowAndroid is therefore dependent on the CleanupReference implementation, and possibly the implementation of the JVM as well. Making the AwContents DestroyRunnable strongly reference the associated WindowAndroidWrapper enforces the correct ordering. BUG=595336 Review URL: https://codereview.chromium.org/1809643002 Cr-Commit-Position: refs/heads/master@{#381675} (cherry picked from commit 81a813fcee09c1ed0f299aba3b589e3705238875) BUG=599216 Committed: https://chromium.googlesource.com/chromium/src/+/beebc994b0b69df0b32921601ff32506f2664254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
boliu
4 years, 8 months ago (2016-03-30 21:50:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
beebc994b0b69df0b32921601ff32506f2664254.

Powered by Google App Engine
This is Rietveld 408576698