Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1845063002: Revert of Remove font cache code (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove font cache code (patchset #3 id:40001 of https://codereview.chromium.org/1834763003/ ) Reason for revert: Speculative revert for causing failures: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8216 Original issue's description: > Delete font cache code and switch to font proxy by default. > > This change will remove the font cache codepath. This also > removes support for the DirectWriteFontProxy field trial > (currently at 100% in all channels) and switches the font > proxy to be the default codepath. > > BUG=525142 > > Committed: https://crrev.com/80b563a7c76146dd154f5c958cc3cb22ea7b7bc4 > Cr-Commit-Position: refs/heads/master@{#384068} TBR=jochen@chromium.org,ananta@chromium.org,jschuh@chromium.org,scottmg@chromium.org,kulshin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=525142 Committed: https://crrev.com/a9d0fa26f4f6223b55b4817d06584346c25c6aa8 Cr-Commit-Position: refs/heads/master@{#384102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1679 lines, -8 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 4 chunks +43 lines, -0 lines 0 comments Download
M chrome/chrome_utility.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/utility/font_cache_handler_win.h View 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/utility/font_cache_handler_win.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M content/child/font_warmup_win.h View 2 chunks +11 lines, -0 lines 0 comments Download
M content/child/font_warmup_win.cc View 4 chunks +70 lines, -1 line 0 comments Download
A content/common/dwrite_font_platform_win.cc View 1 chunk +1282 lines, -0 lines 0 comments Download
A content/common/dwrite_font_platform_win_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M content/common/sandbox_win.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M content/content_common.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 3 chunks +11 lines, -4 lines 0 comments Download
A content/public/common/dwrite_font_platform_win.h View 1 chunk +47 lines, -0 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M content/test/layouttest_support.cc View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Devlin
Created Revert of Remove font cache code
4 years, 8 months ago (2016-03-30 21:44:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845063002/1
4 years, 8 months ago (2016-03-30 21:45:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 21:46:09 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 21:48:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9d0fa26f4f6223b55b4817d06584346c25c6aa8
Cr-Commit-Position: refs/heads/master@{#384102}

Powered by Google App Engine
This is Rietveld 408576698