Ensure omnibox suggestions are regenerated when deleting the inline autocomplete.

Ensure omnibox suggestions are regenerated when deleting the inline autocomplete.

BUG=599190
Committed: https://crrev.com/1650ad572234af3729dd9b63a5e015bf92f73149
Cr-Commit-Position: refs/heads/master@{#384316}

[Ted C, 2016-03-30 20:47:51]

tedchoc@chromium.org changed reviewers:
+ newt@chromium.org

[Ted C, 2016-03-30 20:47:52]

PTAL

[newt (away), 2016-03-30 20:57:38]

lgtm modulo comments

https://codereview.chromium.org/1845033002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
(right):

https://codereview.chromium.org/1845033002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java:364:
mBeforeBatchEditAutocompleteText = getTextWithoutAutocomplete();
The name "mBeforeBatchEditAutocompleteText" seems backwards. This is actually
the text *without* the autocomplete bit, right? Not sure if there's a standard
term for that part of the text.

https://codereview.chromium.org/1845033002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java:365:
mBeforeBatchEditFullText = getText().toString();
Alternatively, you could store the full text + the index at which the inline
autocomplete span begins.

[newt (away), 2016-03-30 20:57:59]

Third time's the charm :)

[Ted C, 2016-03-31 16:44:02]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-03-31 16:44:02]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1845033002/#ps20001
(title: "Address newt@ comments")

[commit-bot: I haz the power, 2016-03-31 16:44:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845033002/20001

[Ted C, 2016-03-31 16:46:28]

https://codereview.chromium.org/1845033002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
(right):

https://codereview.chromium.org/1845033002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java:365:
mBeforeBatchEditFullText = getText().toString();
On 2016/03/30 20:57:38, newt wrote:
> Alternatively, you could store the full text + the index at which the inline
> autocomplete span begins.

Good idea on storing just the index, converted to that.

[commit-bot: I haz the power, 2016-03-31 17:26:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 17:28:05]

Description was changed from

==========
Ensure omnibox suggestions are regenerated when deleting the inline
autocomplete.

BUG=599190
==========

to

==========
Ensure omnibox suggestions are regenerated when deleting the inline
autocomplete.

BUG=599190

Committed: https://crrev.com/1650ad572234af3729dd9b63a5e015bf92f73149
Cr-Commit-Position: refs/heads/master@{#384316}
==========

[commit-bot: I haz the power, 2016-03-31 17:28:06]

Patchset 2 (id:??) landed as
https://crrev.com/1650ad572234af3729dd9b63a5e015bf92f73149
Cr-Commit-Position: refs/heads/master@{#384316}