Enable building with Native Client.

Enable building with Native Client.

This requires you don't have target_os=["ios"] set in your
libyuv root .gclient file, since that will make native_client not
being downloaded due to
https://code.google.com/p/chromium/codesearch#chromium/src/DEPS&l=357

BUG=libyuv:573
TESTED=
rm chromium/.last_sync_chromium
rm chromium/.gclient.tmp_entries
gclient sync
native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0 -Duse_system_yasm=0
ninja -C out/Debug

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/361d8b8156f0695609c9653b4851f57231161244

[fbarchard1, 2016-04-01 01:18:47]

fbarchard@google.com changed reviewers:
+ fbarchard@google.com

[fbarchard1, 2016-04-01 01:18:47]

Could you update readme.md to show how to compile for nacl?
I can work thru the build warnings, but we usually turn those ones off for
gcc/clang?

[kjellander_chromium, 2016-04-06 17:52:38]

kjellander@chromium.org changed reviewers:
+ bradnelson@chromium.org

[kjellander_chromium, 2016-04-06 17:52:38]

As I wrote in https://bugs.chromium.org/p/libyuv/issues/detail?id=573: 
 I'm still not certain this is the "right way" to build for NaCl.
I'm leaning towards that it's maybe just enough to generate the libyuv_nacl
target in libyuv_nacl.gyp and build that?

Then the command will be just native_client/build/gyp_nacl libyuv_nacl.gyp 
It will require some GYP hacking for it to find
native_client/build/untrusted.gypi but that's solvable.

bradnelson: what's your take on this?

[bradn, 2016-04-06 19:23:03]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-04-06 19:23:03]

This looks reasonable.
I mean it turns off the explicit disabling of nacl that was there before 
(I assume for speed).

[fbarchard1, 2016-04-06 22:49:32]

jpeg fails?

native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
Updating projects from gyp files...
gyp: name 'use_system_yasm' is not defined while evaluating condition
'use_system_yasm==1' in chromium/src/third_party/libjpeg_turbo/libjpeg.gyp

[kjellander_chromium, 2016-04-07 06:59:09]

On 2016/04/06 19:23:03, bradn wrote:
> This looks reasonable.
> I mean it turns off the explicit disabling of nacl that was there before 
> (I assume for speed).

IIRC the GYP_DEFINES for disable_nacl=1 was only there to save time during
runhooks since it skipped downloading the NaCl toolchain (we do the same for
WebRTC).
What I'm asking for is which way it makes sense to build libyuv to avoid
regressions for NaCl in Chromium.
Me, knowing just about nothing about NaCl build, figured it would be possible to
generate the projects using:
native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
(like I wrote in the CL description). Then compilation fails due to different
warning levels etc, which of course can be fixed.

Then I noticed there's already a special GYP file for NaCl for libyuv:
libyuv_nacl.gyp.
If I generate the projects using native_client/build/gyp_nacl libyuv_nacl.gyp 
instead (after modifying libyuv_nacl.gyp locally to make it find the
native_client/build/untrusted.gypi) - compilation passes.

Which of the two approaches above makes sense to run on a libyuv bot?

[kjellander_chromium, 2016-04-07 06:59:59]

On 2016/04/06 22:49:32, fbarchard1 wrote:
> jpeg fails?
> 
> native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
> Updating projects from gyp files...
> gyp: name 'use_system_yasm' is not defined while evaluating condition
> 'use_system_yasm==1' in chromium/src/third_party/libjpeg_turbo/libjpeg.gyp

Right, I haven't been able to figure out how to get these set properly using the
GYP files. Until figured out, use this:
native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
-Duse_system_yasm=0

[kjellander_chromium, 2016-04-07 07:00:01]

On 2016/04/06 22:49:32, fbarchard1 wrote:
> jpeg fails?
> 
> native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
> Updating projects from gyp files...
> gyp: name 'use_system_yasm' is not defined while evaluating condition
> 'use_system_yasm==1' in chromium/src/third_party/libjpeg_turbo/libjpeg.gyp

Right, I haven't been able to figure out how to get these set properly using the
GYP files. Until figured out, use this:
native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
-Duse_system_yasm=0

[kjellander_chromium, 2016-04-11 20:09:52]

Description was changed from

==========
Enable building with Native Client.

This requires you don't have target_os=["ios"] set in your
libyuv root .gclient file, since that will make native_client not
being downloaded due to
https://code.google.com/p/chromium/codesearch#chromium/src/DEPS&l=357

WIP: Compilation doesn't pass yet.

BUG=libyuv:573
TESTED=
rm chromium/.last_sync_chromium
rm chromium/.gclient.tmp_entries
gclient sync
native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
ninja -C out/Debug
==========

to

==========
Enable building with Native Client.

This requires you don't have target_os=["ios"] set in your
libyuv root .gclient file, since that will make native_client not
being downloaded due to
https://code.google.com/p/chromium/codesearch#chromium/src/DEPS&l=357

BUG=libyuv:573
TESTED=
rm chromium/.last_sync_chromium
rm chromium/.gclient.tmp_entries
gclient sync
native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
-Duse_system_yasm=0
ninja -C out/Debug
==========

[kjellander_chromium, 2016-04-11 20:11:04]

On 2016/04/07 07:00:01, kjellander (chromium) wrote:
> On 2016/04/06 22:49:32, fbarchard1 wrote:
> > jpeg fails?
> > 
> > native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
> > Updating projects from gyp files...
> > gyp: name 'use_system_yasm' is not defined while evaluating condition
> > 'use_system_yasm==1' in chromium/src/third_party/libjpeg_turbo/libjpeg.gyp
> 
> Right, I haven't been able to figure out how to get these set properly using
the
> GYP files. Until figured out, use this:
> native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
> -Duse_system_yasm=0

I'll commit this as it and we can work out the last compilation errors in
follow-up CLs.

Brad: I'm still wondering what the right way to prevent regressions in Chromium
is, see comment #8 above.

[fbarchard, 2016-04-11 21:48:07]

On 2016/04/11 20:11:04, kjellander (chromium) wrote:
> On 2016/04/07 07:00:01, kjellander (chromium) wrote:
> > On 2016/04/06 22:49:32, fbarchard1 wrote:
> > > jpeg fails?
> > > 
> > > native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable
-Dmsan=0
> > > Updating projects from gyp files...
> > > gyp: name 'use_system_yasm' is not defined while evaluating condition
> > > 'use_system_yasm==1' in chromium/src/third_party/libjpeg_turbo/libjpeg.gyp
> > 
> > Right, I haven't been able to figure out how to get these set properly using
> the
> > GYP files. Until figured out, use this:
> > native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
> > -Duse_system_yasm=0
> 
> I'll commit this as it and we can work out the last compilation errors in
> follow-up CLs.
> 
> Brad: I'm still wondering what the right way to prevent regressions in
Chromium
> is, see comment #8 above.

lgtm

[fbarchard, 2016-04-11 21:49:02]

On 2016/04/11 21:48:07, fbarchard wrote:
> On 2016/04/11 20:11:04, kjellander (chromium) wrote:
> > On 2016/04/07 07:00:01, kjellander (chromium) wrote:
> > > On 2016/04/06 22:49:32, fbarchard1 wrote:
> > > > jpeg fails?
> > > > 
> > > > native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable
> -Dmsan=0
> > > > Updating projects from gyp files...
> > > > gyp: name 'use_system_yasm' is not defined while evaluating condition
> > > > 'use_system_yasm==1' in
chromium/src/third_party/libjpeg_turbo/libjpeg.gyp
> > > 
> > > Right, I haven't been able to figure out how to get these set properly
using
> > the
> > > GYP files. Until figured out, use this:
> > > native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable
-Dmsan=0
> > > -Duse_system_yasm=0
> > 
> > I'll commit this as it and we can work out the last compilation errors in
> > follow-up CLs.
> > 
> > Brad: I'm still wondering what the right way to prevent regressions in
> Chromium
> > is, see comment #8 above.
> 
> lgtm

Note: I checked in a libjpeg_turbo change to fix the previous build error.

[kjellander_chromium, 2016-04-12 04:40:06]

Description was changed from

==========
Enable building with Native Client.

This requires you don't have target_os=["ios"] set in your
libyuv root .gclient file, since that will make native_client not
being downloaded due to
https://code.google.com/p/chromium/codesearch#chromium/src/DEPS&l=357

BUG=libyuv:573
TESTED=
rm chromium/.last_sync_chromium
rm chromium/.gclient.tmp_entries
gclient sync
native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
-Duse_system_yasm=0
ninja -C out/Debug
==========

to

==========
Enable building with Native Client.

This requires you don't have target_os=["ios"] set in your
libyuv root .gclient file, since that will make native_client not
being downloaded due to
https://code.google.com/p/chromium/codesearch#chromium/src/DEPS&l=357

BUG=libyuv:573
TESTED=
rm chromium/.last_sync_chromium
rm chromium/.gclient.tmp_entries
gclient sync
native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0
-Duse_system_yasm=0
ninja -C out/Debug

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/361d8b8156f0695609c9653b485...
==========

[kjellander_chromium, 2016-04-12 04:40:08]

Committed patchset #2 (id:20001) manually as
361d8b8156f0695609c9653b4851f57231161244 (presubmit successful).