Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1844993003: chrome_junit_tests: Update BUILD.gn to allow building with Java 1.8 (Closed)

Created:
4 years, 8 months ago by dewittj
Modified:
4 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome_junit_tests: Update BUILD.gn to allow building with Java 1.8 Looks like dependency management works a little differently than 1.7 does. BUG=599168 Committed: https://crrev.com/44af6ef24f6a9bc2822e4f294919ae71f7288015 Cr-Commit-Position: refs/heads/master@{#384092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dewittj
ptal, I am not sure why this doesn't happen on the buildbots, so any pointers ...
4 years, 8 months ago (2016-03-30 18:33:25 UTC) #3
newt (away)
lgtm since logically, chrome_junit_tests is allowed to depend on net_java. It would be nice to ...
4 years, 8 months ago (2016-03-30 20:30:13 UTC) #4
dewittj
I updated the description to match our new understanding of root cause. I think it's ...
4 years, 8 months ago (2016-03-30 20:57:05 UTC) #6
newt (away)
On 2016/03/30 20:57:05, dewittj wrote: > I updated the description to match our new understanding ...
4 years, 8 months ago (2016-03-30 21:00:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844993003/1
4 years, 8 months ago (2016-03-30 21:05:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 21:12:05 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 21:13:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44af6ef24f6a9bc2822e4f294919ae71f7288015
Cr-Commit-Position: refs/heads/master@{#384092}

Powered by Google App Engine
This is Rietveld 408576698