Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Side by Side Diff: appengine/logdog/coordinator/backend/util_test.go

Issue 1844963002: Iterate archive query alongside task queue. (Closed) Base URL: https://github.com/luci/luci-go@collector-gae-classic
Patch Set: Respond to code review comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/logdog/coordinator/backend/util.go ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package backend 5 package backend
6 6
7 import ( 7 import (
8 "fmt"
9 "net/http" 8 "net/http"
10 "sort" 9 "sort"
11 10
12 "github.com/julienschmidt/httprouter" 11 "github.com/julienschmidt/httprouter"
13 tq "github.com/luci/gae/service/taskqueue" 12 tq "github.com/luci/gae/service/taskqueue"
14 "github.com/luci/luci-go/appengine/logdog/coordinator" 13 "github.com/luci/luci-go/appengine/logdog/coordinator"
15 "github.com/luci/luci-go/common/logdog/types" 14 "github.com/luci/luci-go/common/logdog/types"
16 "github.com/luci/luci-go/server/middleware" 15 "github.com/luci/luci-go/server/middleware"
17 "golang.org/x/net/context" 16 "golang.org/x/net/context"
18 17
(...skipping 23 matching lines...) Expand all
42 for i, t := range expected { 41 for i, t := range expected {
43 tasks[i] = t.(string) 42 tasks[i] = t.(string)
44 } 43 }
45 44
46 sort.Strings(al) 45 sort.Strings(al)
47 sort.Strings(tasks) 46 sort.Strings(tasks)
48 return ShouldResemble(al, tasks) 47 return ShouldResemble(al, tasks)
49 } 48 }
50 49
51 func archiveTaskName(path string) string { 50 func archiveTaskName(path string) string {
52 » return fmt.Sprintf("archive-%s", coordinator.LogStreamFromPath(types.Str eamPath(path)).HashID()) 51 » return archiveTaskNameForHash(coordinator.LogStreamFromPath(types.Stream Path(path)).HashID())
53 } 52 }
OLDNEW
« no previous file with comments | « appengine/logdog/coordinator/backend/util.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698