devtools: download shell binaries and set origin when run w/ --mojo-version.

devtools: download shell binaries and set origin when run w/ --mojo-version.

Before, a user of devtools that wanted to use prebuilt mojo at particular
version, had to:

 - set up DEPS hooks and use GN build rules that together downloaded and copied
   the shell and the network service at the correct version to the output
   directory
 - set the --origin to point to deployed mojo services at particular version

This patch adds a --mojo-version flag that does all of the above, downloading
binaries as needed and setting the origin accordingly.

Once consumers switch over to --mojo-version, we can retire the GN rules for
downloading prebuilt shells.

Fixes https://github.com/domokit/devtools/issues/62.
Fixes https://github.com/domokit/devtools/issues/63.

R=qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/da012592f169e8c531e4a92cdf00d3c39413dd34

[ppi, 2016-03-31 14:17:52]

Description was changed from

==========
devtools: download shell binaries and set origin when run w/ --mojo-version.

Before, a user of devtools that wanted to use prebuilt mojo at particular
version, had to:

 - set up DEPS hookis and use GN build rules that together downloaded and copied
   the shell and the network service at the correct version to the output
   directory
 - set the --origin to point to deployed mojo services at particular version

This patch adds a --mojo-version flag that does all of the above, downloading
binaries as needed and setting the origin accordingly.

Once consumers switch over to --mojo-version, we can retire the GN rules for
downloading prebuilt shells.

Fixes https://github.com/domokit/devtools/issues/62.
Fixes https://github.com/domokit/devtools/issues/63.
==========

to

==========
devtools: download shell binaries and set origin when run w/ --mojo-version.

Before, a user of devtools that wanted to use prebuilt mojo at particular
version, had to:

 - set up DEPS hooks and use GN build rules that together downloaded and copied
   the shell and the network service at the correct version to the output
   directory
 - set the --origin to point to deployed mojo services at particular version

This patch adds a --mojo-version flag that does all of the above, downloading
binaries as needed and setting the origin accordingly.

Once consumers switch over to --mojo-version, we can retire the GN rules for
downloading prebuilt shells.

Fixes https://github.com/domokit/devtools/issues/62.
Fixes https://github.com/domokit/devtools/issues/63.
==========

[ppi, 2016-03-31 14:17:53]

ppi@chromium.org changed reviewers:
+ qsr@chromium.org

[ppi, 2016-03-31 14:22:34]

Hi Ben,

ptal. cc: PY, Trung

[ppi, 2016-03-31 14:35:52]

Updated docs in `mojo_run.md` in patch set 3.

[qsr, 2016-03-31 14:39:15]

https://codereview.chromium.org/1844943004/diff/20001/mojo/devtools/common/de...
File mojo/devtools/common/devtoolslib/download.py (right):

https://codereview.chromium.org/1844943004/diff/20001/mojo/devtools/common/de...
mojo/devtools/common/devtoolslib/download.py:1: # Copyright 2015 The Chromium
Authors. All rights reserved.
This is so last year.

https://codereview.chromium.org/1844943004/diff/20001/mojo/devtools/common/de...
mojo/devtools/common/devtoolslib/download.py:56: # throw the output away if the
script succeeds (return code 0).
I do not see the code to do any of this. What am I missing?

[ppi, 2016-03-31 15:08:51]

Thanks, ptal.

https://codereview.chromium.org/1844943004/diff/20001/mojo/devtools/common/de...
File mojo/devtools/common/devtoolslib/download.py (right):

https://codereview.chromium.org/1844943004/diff/20001/mojo/devtools/common/de...
mojo/devtools/common/devtoolslib/download.py:1: # Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/03/31 14:39:15, qsr wrote:
> This is so last year.

Fixed.

https://codereview.chromium.org/1844943004/diff/20001/mojo/devtools/common/de...
mojo/devtools/common/devtoolslib/download.py:56: # throw the output away if the
script succeeds (return code 0).
On 2016/03/31 14:39:15, qsr wrote:
> I do not see the code to do any of this. What am I missing?

Redacted. This was carried over from mojo/public/tools/pylib/gs.py.

[qsr, 2016-03-31 15:18:01]

lgtm

[ppi, 2016-04-01 22:54:27]

Description was changed from

==========
devtools: download shell binaries and set origin when run w/ --mojo-version.

Before, a user of devtools that wanted to use prebuilt mojo at particular
version, had to:

 - set up DEPS hooks and use GN build rules that together downloaded and copied
   the shell and the network service at the correct version to the output
   directory
 - set the --origin to point to deployed mojo services at particular version

This patch adds a --mojo-version flag that does all of the above, downloading
binaries as needed and setting the origin accordingly.

Once consumers switch over to --mojo-version, we can retire the GN rules for
downloading prebuilt shells.

Fixes https://github.com/domokit/devtools/issues/62.
Fixes https://github.com/domokit/devtools/issues/63.
==========

to

==========
devtools: download shell binaries and set origin when run w/ --mojo-version.

Before, a user of devtools that wanted to use prebuilt mojo at particular
version, had to:

 - set up DEPS hooks and use GN build rules that together downloaded and copied
   the shell and the network service at the correct version to the output
   directory
 - set the --origin to point to deployed mojo services at particular version

This patch adds a --mojo-version flag that does all of the above, downloading
binaries as needed and setting the origin accordingly.

Once consumers switch over to --mojo-version, we can retire the GN rules for
downloading prebuilt shells.

Fixes https://github.com/domokit/devtools/issues/62.
Fixes https://github.com/domokit/devtools/issues/63.

R=qsr@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/da012592f169e8c531e4a92cdf0...
==========

[ppi, 2016-04-01 22:54:29]

Committed patchset #5 (id:80001) manually as
da012592f169e8c531e4a92cdf00d3c39413dd34 (presubmit successful).