Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 1844933002: Stop retrying failing tests on Safari (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index a4abf476111dde3e5259c439fcd60c53350784b6..0fe9f188aca33f1c2957021eb9f0426c6eef8c5d 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -2634,16 +2634,6 @@ class ReplayingCommandExecutor implements CommandExecutor {
}
bool shouldRetryCommand(CommandOutput output) {
- var command = output.command;
- // We rerun tests on Safari because 6.2 and 7.1 are flaky. Issue 21434.
- if (command is BrowserTestCommand &&
- command.retry &&
- command.browser == 'safari' &&
- output is BrowserControllerTestOutcome &&
- output._rawOutcome != Expectation.PASS) {
- return true;
- }
-
if (!output.successful) {
List<String> stdout, stderr;
@@ -2668,6 +2658,7 @@ bool shouldRetryCommand(CommandOutput output) {
}
// We currently rerun dartium tests, see issue 14074.
+ final command = output.command;
if (command is BrowserTestCommand &&
command.retry &&
command.browser == 'dartium') {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698