Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1844843004: Set the data path of StoragePartition correctly. (Closed)

Created:
4 years, 8 months ago by horo
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, wjmaclean, jam, erg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the data path of StoragePartition correctly. https://crrev.com/1737933002 accidentally changed the path which is used while initializing IndexedDBContextImpl, CacheStorageContextImpl, ServiceWorkerContextWrapper, WebRTCIdentityStore and PlatformNotificationContextImpl. This |path| must be |partition_path| when |in_memory| is false. BUG=598314, 586194 Committed: https://crrev.com/4ee3cce199999c1b21c7cdf9d3f0e19cbc752e1b Cr-Commit-Position: refs/heads/master@{#384829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/browser/storage_partition_impl.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
horo
nhiroki@ Please review this.
4 years, 8 months ago (2016-03-31 08:20:18 UTC) #3
nhiroki
LGTM Hmm... each storage context takes a storage path in a different way. It looks ...
4 years, 8 months ago (2016-03-31 10:18:21 UTC) #4
horo
jam@ Could you please review this?
4 years, 8 months ago (2016-03-31 22:45:59 UTC) #6
Elliot Glaysher
lgtm
4 years, 8 months ago (2016-04-01 17:20:15 UTC) #8
jam
lgtm
4 years, 8 months ago (2016-04-01 17:45:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844843004/1
4 years, 8 months ago (2016-04-03 08:41:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-03 10:02:00 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-03 10:03:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ee3cce199999c1b21c7cdf9d3f0e19cbc752e1b
Cr-Commit-Position: refs/heads/master@{#384829}

Powered by Google App Engine
This is Rietveld 408576698